Comment 1 for bug 1584179

Reviewed: https://review.openstack.org/316113
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=081fc4860b7ba3a87020d2ddae006f667616fed0
Submitter: Jenkins
Branch: master

commit 081fc4860b7ba3a87020d2ddae006f667616fed0
Author: Rodrigo Barbieri <email address hidden>
Date: Fri May 13 10:23:46 2016 -0300

    Fix HDS HNAS errors caused by incorrect IDs

    When attempting to allow_access on a managed share, it fails
    because the proper share ID is not retrieved from private storage
    prior to attempting to validate that the share exists in the
    backend. The same happens when trying to create a share from a
    snapshot created from a managed share, the proper share ID is
    not retrieved from private storage. While we are dealing with
    two possible different IDs it is important to properly display
    the API share ID in log messages so it can be matched to the
    share instances ID, and not all log messages are accurately doing
    so.

    This change addresses this by retrieving the ID from
    private storage first for update_access and
    create_share_from_snapshot operations. The proper unit test changes
    included in this patch required a refactor of several IDs to ensure
    this problem is addressed in unit tests, thus it made sense to
    address several bugs caused by the same problem, having the same fix
    and requiring modifications to the same lines of code.

    Closes-bug: #1581541
    Closes-bug: #1584179
    Closes-bug: #1583785
    Change-Id: I8cdb1a8a72a4ac7e710f57e3c288d48cd2adf0dd