Comment 3 for bug 1582346

Reviewed: https://review.openstack.org/317069
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=4c3c7e5fa4ac49cd7c4fae8eb54163ea64e0fa9e
Submitter: Jenkins
Branch: master

commit 4c3c7e5fa4ac49cd7c4fae8eb54163ea64e0fa9e
Author: Tom Barron <email address hidden>
Date: Sat May 14 08:34:08 2016 -0400

    Fix context warning spam of scheduler and share logs

    Manila share and scheduler logs are littered with warnings about dropped
    kwargs when creating request context. Here is an example:

    2016-04-18 17:08:16.103 WARNING manila.context [-] Arguments dropped
    when creating context: {u'read_only': False, u'domain': None,
    u'show_deleted': False, u'user_identity':
    u'6133ebc001384629a4a9ecfc630bb26b 21b76a623d104713845b686526c10720 - -
    -', u'project_domain': None, u'resource_uuid': None, u'user_domain':
    None}.

    These are currently "just noise". Their meaning is not evident without
    code study, and they cause confusion and alarm to cloud operators,
    resulting in unnecessary support calls and ultimately in a reduction
    in value and credibility of our logging system.

    In manila share log these messages occur on every CRUD operation.
    In manila scheduler the situation is even worse as they occur on every
    periodic capabilities/capacity update.

    Fix this spam by only sending this warning when we receive truly
    unexpected kwargs by following the nova fix [1] for essentially
    the same issue in that project.

    Closes-Bug: #1582346

    [1] Ia47d4909d2656d6fc4c1179659b8098bba3235d3

    Change-Id: Ieba91b42ef680b353dbb326667580bf482ff8d48