OpenStack Shared File Systems Service (Manila)

  1. Bug #1512207
  2. Comment #65

Comment 65 for bug 1512207

Revision history for this message
Eric Harney (eharney) wrote :

sandeep nandal (nandal) wrote 5 hours ago: #59
> Is it OK to use assertFalse()?
> Because It judges 'None' as no failure.
> When developer forgets to return 'False' or 'True', assertFalse() can not detect that.

I would say no, and in fact we declined doing this in Cinder because of this. assertFalse() is a weaker assertion than assertEqual(False, *), which means more issues can slip through the unit tests. Replacing these wholesale is not a good idea.