sandeep nandal (nandal) wrote 5 hours ago: #59
> Is it OK to use assertFalse()?
> Because It judges 'None' as no failure.
> When developer forgets to return 'False' or 'True', assertFalse() can not detect that.
I would say no, and in fact we declined doing this in Cinder because of this. assertFalse() is a weaker assertion than assertEqual(False, *), which means more issues can slip through the unit tests. Replacing these wholesale is not a good idea.
sandeep nandal (nandal) wrote 5 hours ago: #59
> Is it OK to use assertFalse()?
> Because It judges 'None' as no failure.
> When developer forgets to return 'False' or 'True', assertFalse() can not detect that.
I would say no, and in fact we declined doing this in Cinder because of this. assertFalse() is a weaker assertion than assertEqual(False, *), which means more issues can slip through the unit tests. Replacing these wholesale is not a good idea.