Manila is broken is threee places, so fix them:
1) test 'test_misc' with WebOb 1.5
WebOb 1.5 was released at 2015-10-11. With this new version,
webob.exc.WSGIHTTPException() constructor now fails with a KeyError
when the HTTP status code is 0.
test_exceptions_raise() of test_misc tries to instantiate all
exceptions of manila.exception. The problem is that
ConvertedException uses a default HTTP status code of 0.
Modify the default HTTP status code of ConvertedException to 400 to
fix the unit tests.
2) Add dependency for 'testresources' that is required by migration
tests.
3) Remove 2 unit tests related to testing of oslo.policy lib
functionality that should not be tested in Manila. It started failing
because under-the-hood behaviour was changed in new realese 0.12.0
Closes-Bug: #1505153
Closes-Bug: #1505374
(cherry picked from commit 9c99814ce5943bd4c33bf3650b832666e31b3411)
-- squashed with another change to get tests to pass on stable/liberty --
Fix broken unit tests
With release of six module version 1.10.0 several our unit tests
started to fail because of usage of not strict constructions.
Changes:
1) Manila unit test
"manila.tests.share.test_api.ShareAPITestCase.test_extend_quota_error"
used str for int substitution. So, use int data for int substitution.
2) Module 'manila.share.drivers.hp.hp_3par_mediator' was using
LOG.exception function when no traceback were exist it led to
AttributeError on py34. So, replace all usages of 'LOG.exception'
with 'LOG.error' where no raised exceptions exist.
Change-Id: Ic5b37bfb9d939d03f6ff68bc53d134bf9e5f996e
Closes-Bug: #1503969
(cherry picked from commit f38b8d4efd1f68f4ea29747f7377e0936f61d89c)
Reviewed: https:/ /review. openstack. org/234288 /git.openstack. org/cgit/ openstack/ manila/ commit/ ?id=f1eded1fbca f309e1c9a4be3f8 a14bd25daa3e46
Committed: https:/
Submitter: Jenkins
Branch: stable/liberty
commit f1eded1fbcaf309 e1c9a4be3f8a14b d25daa3e46
Author: Gaurang Tapase <email address hidden>
Date: Mon Oct 12 20:47:19 2015 +0530
Fix usage of dependencies
Manila is broken is threee places, so fix them:
1) test 'test_misc' with WebOb 1.5
WebOb 1.5 was released at 2015-10-11. With this new version, exc.WSGIHTTPExc eption( ) constructor now fails with a KeyError
webob.
when the HTTP status code is 0.
test_ exceptions_ raise() of test_misc tries to instantiate all ception uses a default HTTP status code of 0.
exceptions of manila.exception. The problem is that
ConvertedEx
Modify the default HTTP status code of ConvertedException to 400 to
fix the unit tests.
2) Add dependency for 'testresources' that is required by migration
tests.
3) Remove 2 unit tests related to testing of oslo.policy lib
functionality that should not be tested in Manila. It started failing
because under-the-hood behaviour was changed in new realese 0.12.0
Closes-Bug: #1505153
Closes-Bug: #1505374
(cherry picked from commit 9c99814ce5943bd 4c33bf3650b8326 66e31b3411)
-- squashed with another change to get tests to pass on stable/liberty --
Fix broken unit tests
With release of six module version 1.10.0 several our unit tests
started to fail because of usage of not strict constructions.
Changes: tests.share. test_api. ShareAPITestCas e.test_ extend_ quota_error"
1) Manila unit test
"manila.
used str for int substitution. So, use int data for int substitution.
2) Module 'manila. share.drivers. hp.hp_3par_ mediator' was using
LOG.exception function when no traceback were exist it led to
AttributeError on py34. So, replace all usages of 'LOG.exception'
with 'LOG.error' where no raised exceptions exist.
Change-Id: Ic5b37bfb9d939d 03f6ff68bc53d13 4bf9e5f996e 4ea29747f7377e0 936f61d89c)
Closes-Bug: #1503969
(cherry picked from commit f38b8d4efd1f68f
--
Change-Id: I0f28f3c3fb2c7e ec1bafc3a617344 990f86810cf