Comment 3 for bug 827697

Revision history for this message
Barry Warsaw (barry) wrote :

I'm almost positive none of the built-in chain's rules are checking msgdata['approved'] or msgdata['moderator_approved'] and jumping to the accept chain. So when handle_message() dumps the message back into the 'in' queue, it just runs through the rules and hits the same hold criteria as before.

I have to think about the right way to fix this. One way is to add a rule that just checks one of those metadata keys and then jumps to the accept chain. That'd be the easy way to solve this. OTOH, once a message has been accepted by the moderator, it doesn't make much sense to run through the built-in chain again. I don't know whether that means the message should go straight to the pipeline queue instead of the incoming queue, or whether it should go to the incoming queue with a custom chain. However, there's currently no way to specify a different chain for a message to run through (i.e. via some metadata key).

I'll have to think on this one a bit.