GNU Mailman

  1. Bug #558281 (sf-1798683)
  2. Comment #1

Comment 1 for bug 558281

Revision history for this message
msapiro (msapiro-users) wrote :

Logged In: YES
user_id=1123998
Originator: NO

The patch seems good except if SMTP_USE_TLS is set True in mm_cfg.py, the patch references mm_cfg.SMTP_HELO_HOST which is neither defined nor documented in the patch.

Perhaps the patch to Defaults.py.in should include something like

SMTP_HELO_HOST = DEFAULT_EMAIL_HOST

or even

SMTP_HELO_HOST = ''

and some comments describing what all the new variables are.