'rejection-notice' breaks METAFMT_ASCII

Bug #557951 reported by mdornseif
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNU Mailman
Fix Released
High
Unassigned

Bug Description

The variable 'rejection-notice' will not work well with
METADATA_FORMAT = METAFMT_ASCII or HOLD_MESSAGES_AS_PICKLES = 0.
Renaming to 'rejection_notice' helps.

I guess this change breaks kompatibility with old queues.

In case SF.net upload breaks:
http://c0re.jp/c0de/misc/mailman-2.1b2-rejection-notice.patch

Index: ./Mailman/Cgi/admindb.py
- text = Utils.wrap(msgdata.get('rejection-notice',
+ text = Utils.wrap(msgdata.get('rejection_notice',
Index: ./Mailman/Handlers/Hold.py
- msgdata['rejection-notice'] = Utils.wrap(exc.rejection_notice(mlist))
+ msgdata['rejection_notice'] = Utils.wrap(exc.rejection_notice(mlist))

Revision history for this message
mdornseif (mdornseif) wrote :

The file mailman-2.1b2-rejection-n.patch was added: mailman-2.1b2-rejection-notice.patch

Revision history for this message
bwarsaw (bwarsaw) wrote :

Logged In: YES
user_id=12800

Note that while I don't think HOLD_MESSAGES_AS_PICKLES is
affected, you're right about METADATA_FORMAT= METAFMT_ASCII.
 This is because that format uses execfile() and dashes
aren't allowed in identifiers.

Fixed, thanks.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.