Comment 3 for bug 266258

Revision history for this message
Schoinobates (schoinobates) wrote :

Originator: NO

In Debian, we fixed that problem with the following patch and running the
following withlist script on all mailing list on upgrade. Let me note in
passing that the code for clearIndex looks very suspicious: it takes an
"index" argument but completely ignores it. It should probably clear its
argument and not be hardcoded to clear the thread index.

--- Mailman/Archiver/HyperDatabase.py 2005-08-27 03:40:17.000000000 +0200
+++ Mailman/Archiver/HyperDatabase.py 2007-02-27 20:33:41.103527160 +0100
@@ -324,15 +343,22 @@

     def clearIndex(self, archive, index):
         self.__openIndices(archive)
         if hasattr(self.threadIndex, 'clear'):
             self.threadIndex.clear()
             return
         finished=0
         try:
             key, msgid=self.threadIndex.first()
         except KeyError: finished=1
         while not finished:
             del self.threadIndex[key]
             try:
                 key, msgid=self.threadIndex.next()
             except KeyError: finished=1
+
+ def mapKeys(self, f, archive, index):
+ self.__openIndices(archive)
+ index = getattr(self, index + 'Index')
+ d = index.dict
+ index.dict = dict(zip(map(f, d.keys()), d.values()))
+ index.__dirty = 1

#! /usr/bin/python
#
# Copyright (C) 2007 Lionel Elie Mamane <email address hidden>
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

"""Convert a list's archive databases to unicode where appropriate

This script is intended to be run as a bin/withlist script, i.e.

% bin/withlist -l -r unicodify_archives <mylist>
"""

import paths
import time
from Mailman.i18n import _
from Mailman import mm_cfg

def unicodify_string(s):
    if isinstance(s,unicode):
        return s
    elif isinstance(s,str):
        try:
            return s.decode()
        except UnicodeDecodeError:
            pass
        try:
            return s.decode('utf-8')
        except UnicodeDecodeError:
            pass
        return s.decode('windows-1252', 'replace')

def unicodify_fst(t):
    l = list(t[1:])
    l.insert(0, unicodify_string(t[0]))
    return tuple(l)

def unicodify_archives(mlist):
    # Only act if we are using the internal archiver
    if mm_cfg.PUBLIC_EXTERNAL_ARCHIVER:
        return
    else:
        from Mailman.Archiver import HyperArch
        h = HyperArch.HyperArchive(mlist)
        currentVolume = h.dateToVolName(time.time())
        if currentVolume in h.archives:
            for hdr in ('subject', 'author'):
                h.database.mapKeys(unicodify_fst, currentVolume, hdr)
        h.close()

if __name__ == '__main__':
    print _(__doc__.replace('%', '%%'))