Remote (MNet) collection submissions fail to release
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Won't Fix
|
High
|
Dianne Tennent |
Bug Description
Mahara 21.04.1
Totara 12.?
Mahara assignment submission 2017101601
Set up MNet Connection from a Moodle/ Totara to Mahara allowing users from Moodle to log in to Mahara
Install Mahara assignment submissions plugin to the Moodle site.
Set up an assignment allowing Mahara submissions
- lock submitted pages after grading
Create a collection as a learner
Log in to Moodle
Submit a Mahara collection to the assignment
Log out
Log in to Moodle as a teacher who does not have an account on Mahara
Grade the submitted assignment and allow a new attempt
Expected
The collection and pages are released and a new attempt is available
Actual
Error is returned: optional_userobj no userid and no logged in user
----
Diagnosis
In /lib/collection.php relase()
$releaseuser = optional_
$releaseuser does not exist.
Called in xmlrpc/lib.php release_
find_remote_
returns no user.
This was introduced in 87f0664d3bae371
Suggested fix
In /lib/collection.php relase()
wrap $releaseuser = optional_
no longer affects: | mahara/20.04 |
Mōrena Jeremy,
Thank you very much for the patch. We'll add it to our code review system. If you wish to push it there next time directly, you are welcome to set up the connection to Gerrit for a more streamlined workflow: https:/ /wiki.mahara. org/wiki/ Developer_ Area/Contributi ng_Code
Ngā mihi
Kristina