Trying to get property of non-object in module/assessmentreport/lib.php line 60

Bug #1908837 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
19.10
Fix Released
High
Unassigned
20.04
Fix Released
High
Unassigned
20.10
Fix Released
High
Unassigned
21.04
Fix Released
High
Unassigned

Bug Description

When releasing a collection and the assessment report is enabled there is an error with the $releaseuser

It is given as a string instead of an object

To test:

1) Have a group that accepts submission and has submission archiving turned on
2) As a group member submit a collection to the group
3) As group admin release the collection
4) Run the cron from command line: sudo -u www-data php htdocs/lib/cron.php

You should see an error similar to
[WAR] a2 (module/assessmentreport/lib.php:60) Trying to get property 'id' of non-object

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 21.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11505

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11505
Committed: https://git.mahara.org/mahara/mahara/commit/214c899aa47cc4fd8ab20e6e80f44e083df6a081
Submitter: Lisa Seeto (<email address hidden>)
Branch: master

commit 214c899aa47cc4fd8ab20e6e80f44e083df6a081
Author: Robert Lyon <email address hidden>
Date: Mon Dec 21 09:51:54 2020 +1300

Bug 1908837: Setting $releaseuser correctly

When archiving a collection

Change-Id: I4c978de93e04dcdedc328f5d31f8dc13d9208159
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11512

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11513

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11514

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11513
Committed: https://git.mahara.org/mahara/mahara/commit/f7bc2071a8107b08b3c70dc4dead81cb2005aa36
Submitter: Lisa Seeto (<email address hidden>)
Branch: 20.04_STABLE

commit f7bc2071a8107b08b3c70dc4dead81cb2005aa36
Author: Robert Lyon <email address hidden>
Date: Mon Dec 21 09:51:54 2020 +1300

Bug 1908837: Setting $releaseuser correctly

When archiving a collection

Change-Id: I4c978de93e04dcdedc328f5d31f8dc13d9208159
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 214c899aa47cc4fd8ab20e6e80f44e083df6a081)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11514
Committed: https://git.mahara.org/mahara/mahara/commit/7e27265dd2f8e4406aada78e9f29a543ad16bbd7
Submitter: Lisa Seeto (<email address hidden>)
Branch: 19.10_STABLE

commit 7e27265dd2f8e4406aada78e9f29a543ad16bbd7
Author: Robert Lyon <email address hidden>
Date: Mon Dec 21 09:51:54 2020 +1300

Bug 1908837: Setting $releaseuser correctly

When archiving a collection

Change-Id: I4c978de93e04dcdedc328f5d31f8dc13d9208159
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 214c899aa47cc4fd8ab20e6e80f44e083df6a081)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11512
Committed: https://git.mahara.org/mahara/mahara/commit/601fbc10f91b512f46c5f9967ec27b6978187ea1
Submitter: Lisa Seeto (<email address hidden>)
Branch: 20.10_STABLE

commit 601fbc10f91b512f46c5f9967ec27b6978187ea1
Author: Robert Lyon <email address hidden>
Date: Mon Dec 21 09:51:54 2020 +1300

Bug 1908837: Setting $releaseuser correctly

When archiving a collection

Change-Id: I4c978de93e04dcdedc328f5d31f8dc13d9208159
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 214c899aa47cc4fd8ab20e6e80f44e083df6a081)

no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.