composer.json settings allow dev versions for php: Specify max version

Bug #1745250 reported by Rebecca Blundell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Rebecca Blundell

Bug Description

Looking at composer.json to see if we should update dependencies to make tests run better, I see that our syntax for php >=5.3.3 allows any version above that specified with default stability as dev. It explains how I ended up with php 7.2 after running make initcomposer...
I think our default stability should be stable and that we should think about specifying a maximum version.

Should we also change our settings to allow some other upgrades if there is a new stable non-breaking release, or just leave things pinned? If we change to "^version", it allows upgrades up to but not including the next major version, which seems reasonable??

Tags: snack-sized
Revision history for this message
Robert Lyon (robertl-9) wrote :

Tagged as snacked-sized as the code change may be small but the initial testing will probably be an effort

As it will involve checking what versions of PHP work fine with current Mahara and which don't

tags: added: snack-sized
Changed in mahara:
importance: Undecided → Wishlist
status: New → Confirmed
importance: Wishlist → High
milestone: none → 19.10.0
summary: - composer.json settings allow dev versions for php
+ composer.json settings allow dev versions for php: Specify max version
Changed in mahara:
milestone: 19.10.0 → 19.10.1
Revision history for this message
Rebecca Blundell (rjb-dev) wrote :

This was fixed in another patch: https://bugs.launchpad.net/mahara/+bug/1772792

no longer affects: mahara/20.04
no longer affects: mahara/19.10
Changed in mahara:
milestone: 20.04.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.