Behat: upgrade for php 7.2
Bug #1772792 reported by
Rebecca Blundell
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Unassigned |
Bug Description
1. Upgrade behat to run in php 7.2
2. Figure out what best to do for this problem:
Currently there is an issue with the Behat2Renderer.php file in the html report. It uses count() as a test whether object properties return null. As in 7.2 passing null to count results in a warning, running tests currently produces a long list of warnings, so we should probably change that.
It looks like implementing Countable on the object may solve this.
description: | updated |
Changed in mahara: | |
status: | New → In Progress |
importance: | Undecided → High |
milestone: | none → 18.10.0 |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Patch for "master" branch: https:/ /reviews. mahara. org/8882