Problems with group forums / topics

[Robert Lyon]

In master:
- the edit/delete buttons for a forum display to normal members (even though they can't edit/delete a forum)
- the ability to subscribe / unsubscribe to a topic in a forum has gone away but the 'i' help still remains

These need to be fixed up

[Robert Lyon (robertl-9)]

Actually the problem with the 'i' help icon is due to a form that displays when you are not subscribed to the forum allowing you to subscribe to only some of the topics

[Steven (stevens-q)]

Manually ran the following Behat test:

@javascript @core @core_view
Feature: Edit and delete Forum nbuttons are not displayed for normal users
    As a normal user and not the author
    I should not be able to see edit and delete buttons
    because I do not have permissions

Background:
Given the following "users" exist:
    | username | password | email | firstname | lastname | institution | authname | role |
    | UserA | Kupuhipa1 | <email address hidden> | Angela | User | mahara | internal | member |
    | UserB | Kupuhipa1 | <email address hidden> | Bob | User | mahara | internal | member |

And the following "groups" exist:
      | name | owner | description | grouptype | open | invitefriends | editroles | submittableto | allowarchives | members | staff |
      | GroupA | UserA | GroupA owned by UserA | standard | ON | ON | all | ON | ON | UserA, UserB | UserA |
      | GroupB | UserB | GroupB owned by UserB | standard | ON | ON | all | ON | ON | UserB, UserA | UserB |

Scenario: Normal members should not see edit/delete forum buttons
 Given I log in as "UserA" with password "Kupuhipa1"
 And I am on "/group/view.php?id=1"
 When I follow "Forums"
 # The following line does not run
 Then I should see "Forums | Group A"
 And I should not see "Edit \"General discussion\""
 And I should not see "Delete \"General discussion\""

 Scenario: Group owner should see edit/delete forum buttons
 Given I log in as "UserB" with password "Kupuhipa1"
 And I am on "/group/view.php?id=2"
 When I follow "Forums"
 # The following line does not run
 Then I should see "Forums | Group B"
  And I should see "Edit \"General discussion\""
 And I should see "Delete \"General discussion\""

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8550
Committed: https://git.mahara.org/mahara/mahara/commit/af02288f85a039b75fe3ba3a3527b07189a2aa42
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit af02288f85a039b75fe3ba3a3527b07189a2aa42
Author: Robert Lyon <email address hidden>
Date: Thu Mar 1 11:20:44 2018 +1300

Bug 1752442: Showing edit/delete links to non group admins in forums

Also show a help icon to a form that is not shown

behatnotneeded

Change-Id: I603f42a757bd6b9617e59c1214c3e86e2930d995
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8562

[Mahara Bot (dev-mahara)]

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8563

[Mahara Bot (dev-mahara)]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/8564

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8564
Committed: https://git.mahara.org/mahara/mahara/commit/5b0e6d53ceec2291b96663caec922262feae9a57
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 5b0e6d53ceec2291b96663caec922262feae9a57
Author: Robert Lyon <email address hidden>
Date: Thu Mar 1 11:20:44 2018 +1300

Bug 1752442: Showing edit/delete links to non group admins in forums

Also show a help icon to a form that is not shown

behatnotneeded

Change-Id: I603f42a757bd6b9617e59c1214c3e86e2930d995
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit af02288f85a039b75fe3ba3a3527b07189a2aa42)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8563
Committed: https://git.mahara.org/mahara/mahara/commit/ff109c21cdee312f8d667d38cbe090f3633cfa23
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit ff109c21cdee312f8d667d38cbe090f3633cfa23
Author: Robert Lyon <email address hidden>
Date: Thu Mar 1 11:20:44 2018 +1300

Bug 1752442: Showing edit/delete links to non group admins in forums

Also show a help icon to a form that is not shown

behatnotneeded

Change-Id: I603f42a757bd6b9617e59c1214c3e86e2930d995
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit af02288f85a039b75fe3ba3a3527b07189a2aa42)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8562
Committed: https://git.mahara.org/mahara/mahara/commit/12d0a41121077d6efb8c303307f4678c881d73f0
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 12d0a41121077d6efb8c303307f4678c881d73f0
Author: Robert Lyon <email address hidden>
Date: Thu Mar 1 11:20:44 2018 +1300

Bug 1752442: Showing edit/delete links to non group admins in forums

Also show a help icon to a form that is not shown

behatnotneeded

Change-Id: I603f42a757bd6b9617e59c1214c3e86e2930d995
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit af02288f85a039b75fe3ba3a3527b07189a2aa42)