Replace "delete logo" switch with a checkbox

[Aaron Wells]

I noticed another switchbox that would make more sense as an old-fashioned checkbox. When you upload an institution logo, there's a checkbox to delete the logo the next time you save the institution.

This makes more sense as a checkbox than as a switchbox. The switchbox implies a persistent change in a setting. Like a light switch, it will remain in position until you flick it off. But this particular setting is no persistent. It's just indicating that you want to do an action this one time.

So we should change it back to a checkbox. Or maybe change its text to say "Yes" and "No" rather than "On" and "Off".

To replicate:

1. Edit "No institution"
2. Upload a logo file
3. Save
4. Edit "No institution" again
5. Below the uploaded logo, you'll see a setting to allow you to delete the uploaded logo

Expected result: This should be a checkbox, because it's a one-time action that will be triggered when you hit save

Actual result: It's a switchbox

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/4590

[Robert Lyon (robertl-9)]

I've gone with changing the switchbox text to be yes/no to start with.

If that is still not quite right I'll change it back to a checkbox.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4590
Committed: http://gitorious.org/mahara/mahara/commit/3a1e6e0251f17d25086e1ebab5c4e3217744a812
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 3a1e6e0251f17d25086e1ebab5c4e3217744a812
Author: Robert Lyon <email address hidden>
Date: Fri Apr 10 09:33:05 2015 +1200

Changing the switch's text to yes/no for delete logo (Bug #1442150)

To make the switch button's function more logical.

Change-Id: Ia7714a50c91d7cbf0d9c9c64745b52be62838340
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/4619

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4619
Committed: http://gitorious.org/mahara/mahara/commit/eed165733beebd8347f6dc388d25aacb4ab8fd4c
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit eed165733beebd8347f6dc388d25aacb4ab8fd4c
Author: Robert Lyon <email address hidden>
Date: Fri Apr 10 09:33:05 2015 +1200

Changing the switch's text to yes/no for delete logo (Bug #1442150)

To make the switch button's function more logical.

Change-Id: Ia7714a50c91d7cbf0d9c9c64745b52be62838340
Signed-off-by: Robert Lyon <email address hidden>