Replace "delete logo" switch with a checkbox
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Robert Lyon | ||
15.04 |
Fix Released
|
Medium
|
Robert Lyon | ||
15.10 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
I noticed another switchbox that would make more sense as an old-fashioned checkbox. When you upload an institution logo, there's a checkbox to delete the logo the next time you save the institution.
This makes more sense as a checkbox than as a switchbox. The switchbox implies a persistent change in a setting. Like a light switch, it will remain in position until you flick it off. But this particular setting is no persistent. It's just indicating that you want to do an action this one time.
So we should change it back to a checkbox. Or maybe change its text to say "Yes" and "No" rather than "On" and "Off".
To replicate:
1. Edit "No institution"
2. Upload a logo file
3. Save
4. Edit "No institution" again
5. Below the uploaded logo, you'll see a setting to allow you to delete the uploaded logo
Expected result: This should be a checkbox, because it's a one-time action that will be triggered when you hit save
Actual result: It's a switchbox
Changed in mahara: | |
status: | Fix Committed → Fix Released |
tags: | added: behat needs-behat |
Patch for "master" branch: https:/ /reviews. mahara. org/4590