Comment 9 for bug 1354222

Revision history for this message
Lars (lars-mogwitz) wrote :

Kristina.
You are very welcome to assign me to this. I'd really love to contribute to Mahara.
Though I am a programmer for a decent amount of time now I was never working on an open source project.
Are there any guidelines on how to submit your changes/files and where can I find them?
Thanks in advance you for your help.

Christian.
I agree with you in deleting all files which aren't used in any view and are part of the deleted group.
As you suggested I'd put that into the delete_group() method.

Rather than creating a lookup table for the files, which are still in use I would add kind of the same mechanism to the cron script which searches for files in ALL deleted groups that aren't used in views no more.

I feel like the query I worked on today is fast enough to be executed every time the cron runs with no significant penalty for the cron script's execution time.

I would add the user-messaging when they have a file in one of their views which is part of a deleted group when everything is working fine.

Right now I am working on a test-environment with a huge database of 10.000.000 artefacts, 200,000 views and 200.000 groups to find out two things:
a) Is it necessary to implement this orphan-deleter as a part of the update process when updating to a new version of Mahara or can it be done through the cron
b) Is my query fast enough to be used in huge systems

I think I'll have an answer by the end of next week. Until then I'll play around with my test scenario's settings and let you know.

Kind regards
Lars