On 06/06/12 12:55, Richard Mansfield wrote:
> Also discussed publicly at
> https://mahara.org/interaction/forum/topic.php?id=1727 - in that
> thread Nigel seemed to think it wasn't worth the hassle to filter
> them out, but maybe we should have another look.
Good to see it's been noticed before. To add to the discussion, the
particular trouble with the LDAP case is that the password is almost
invariably going to mean something elsewhere than just Mahara (e.g. in
the Catalyst case, a lot of other systems). If it was just the mahara
password, it wouldn't be quite so bad.
Although I suppose an evil administrator could just modify the PHP and
log the passwords elsewhere.
In this specific case, it looks like the password is passed as a
string argument which gets automatically dumped in the stacktrace.
Perhaps a simple solution would be to embed it in an object which gets
passed around, thus hiding it from exposure in stack traces.
- --
Craig Miskell
Systems Administrator, Catalyst IT
DDI: +64 4 8020427
==
Some of us here are sysadmins, and network admins, and even Windows
admins. Clubbing baby harp seals would a socially acceptable step
*up*. -- butting on ARK
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/06/12 12:55, Richard Mansfield wrote: /mahara. org/interaction /forum/ topic.php? id=1727 - in that
> Also discussed publicly at
> https:/
> thread Nigel seemed to think it wasn't worth the hassle to filter
> them out, but maybe we should have another look.
Good to see it's been noticed before. To add to the discussion, the
particular trouble with the LDAP case is that the password is almost
invariably going to mean something elsewhere than just Mahara (e.g. in
the Catalyst case, a lot of other systems). If it was just the mahara
password, it wouldn't be quite so bad.
Although I suppose an evil administrator could just modify the PHP and
log the passwords elsewhere.
In this specific case, it looks like the password is passed as a
string argument which gets automatically dumped in the stacktrace.
Perhaps a simple solution would be to embed it in an object which gets
passed around, thus hiding it from exposure in stack traces.
- -- enigmail. mozdev. org/
Craig Miskell
Systems Administrator, Catalyst IT
DDI: +64 4 8020427
==
Some of us here are sysadmins, and network admins, and even Windows
admins. Clubbing baby harp seals would a socially acceptable step
*up*. -- butting on ARK
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iQIcBAEBAgAGBQJ PzrETAAoJENezkH +p+mMX3YYP/ 0FLoInTS2OjcfXM j5GY6I5Q hSIQ0T8o/ ZxlaGfi2s8+ MzczS8eXZc6Pk21 eYE0BHBWIS3Z4J yWbrycEYf6dFbuS id8jFqb/ cy6x1ygNbI9XRuz UYn14Nm5sGa Bik41mJvFL6EmFs L0MF5Nrzh7wWXng GxT5vJ7qYXz/ BOrRFaa 0KChXCQG7a7OnRT v6YvRdYX7jJjiA2 SjZAOcuSytVN4Xr cE69 wBzxdPQ713g9eZt FNeCt+nSwXkLFLG Na9jAirbmRLz2kt Dy6e Y6UpgBpX442Ye1B UIK4cqQFNUfqvCc wpGLHo9w70yodOF TSM9 wPH4sOqjkK/ kCNVFG8gbwv0t0F f9HT8CMVlvgUQ4t gAn0Qi3z Z38+hj59G8F08AE AjMbSwW22B5b6Fz Bb7NtRR4GTYoccg loq9g CysWPLD0nakop1H mteSCOW5GZtbXXA ABGUIvyBFkTMb8s 9Opb Q7ZAMzEEkulNnQF /E860dQc0lLC8Nu Lg12U/bmSTnYwNz wUQ7 z8OWg7I
Q3vWS1TIy1ZdYmZ
ptVMF9mO1LowxEU
EMO2u84XdirX49C
HJf9DxqWvJevure
eW7UjyjJf4Wa8pd
SSB73TsPrJw2pbr
n4P3jjKuRXjWXDt
tOR0gsEz6xjFH+
yoCB+Q3006IrGeU
eE3OuLmTYeeIOqw
Hyhf/LxSG253+
=GB8+
-----END PGP SIGNATURE-----