Mahara

  1. Bug #849716
  2. Comment #4

Comment 4 for bug 849716

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/879
Committed: http://gitorious.org/mahara/mahara/commit/4384e74773f660cd24da9e9f2d4deb897eb88e73
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 4384e74773f660cd24da9e9f2d4deb897eb88e73
Author: Richard Mansfield <email address hidden>
Date: Wed Nov 23 18:22:21 2011 +1300

    Remove wwwroot from notification urls (bug #849716)

    Urls stored in the url field of notification_internal_activity contain
    the site's wwwroot. This leads to broken links when the wwwroot is
    changed. It also dangerously turns what should be local links into
    remote ones when for example a production database is copied into a
    test Mahara instance.

    This patch does three things:
    - Removes the wwwroot from urls passed to ActivityType constructors
    - Adds the wwwroot back on the url when sending email and emaildigest
      notifications, and when displaying them on the site.
    - Removes the wwwroot from the url in all existing rows of
      notification_internal_activity.

    Change-Id: I00ae1abc65be79030ed4c572ce951edc43f7a034
    Signed-off-by: Richard Mansfield <email address hidden>