Comment 23 for bug 785472
Revision history for this message
| Mahara Bot (dev-mahara) wrote A change has been merged | #23 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Reviewed: https:/
Committed: http://
Submitter: Robert Lyon (<email address hidden>)
Branch: master
commit 039564a50799e31
Author: Nigel Cunningham <email address hidden>
Date: Wed Jul 30 14:22:15 2014 +1000
(Bug785472) Remove unneeded raise_memory_limit calls
On the basis of my profiling and testing over the last week,
all of the scripts affected by this patch don't need their
raise_memory_limit calls. Ensure_sanity currently sets the
memory limit to 128MB, which has been seen to be more than
sufficient for each of these use cases.
Tests have involved at least 1000 records being imported in
each case, and sometimes as many as 20,000. I would have
liked to have tested with some really full profiles (eg
lots of pictures and content), but am satisfied that there's
enough margin to cover those cases. In any case, such files
are often handled using external apps and therefore won't
be counted toward PHP's memory use anyway. Finally, the
limit can easily be increased by the user if necessary for
a particular case.
Change-Id: Ifecc83fd47da51
Signed-off-by: Nigel Cunningham <email address hidden>