Export to HTML doesn't use selected theme

Bug #739528 reported by Dominique-Alain JAN
68
This bug affects 10 people
Affects Status Importance Assigned to Milestone
Mahara
Wishlist
Unassigned

Bug Description

When a view or views is/are exported, the default "raw" style sheet (theme) is used for display. The export should use the selected theme instead.

Changed in mahara:
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Kevin Stacey (kstacey) wrote :

This would be invaluable for our students. The ability to export with theme would dramatically improve the output appearance.
Yes Please!

Revision history for this message
Ben Shmulevitch (bshmulevitch) wrote :

As a student, the ability to retain the appearance of my views when exported would be a huge bonus. Having a sleek looking portfolio would be a great way to easily show a large body of work to uni's/colleges in the application process.

This way Mahara within schools could be moved into a much more 'online' experience outside the classroom after students leave their school.

Revision history for this message
François Marier (fmarier) wrote :

Related to Bug #739534.

tags: added: export html
Revision history for this message
Katharina Heyligers (katharina-heyligers) wrote :

When students (in our case people in further training / extension studies) investigate many hours in their portfolio, the output appearance should be influenceable. Otherwise it´s not work the effort.
So: yes please!

Revision history for this message
Robert Lyon (robertl-9) wrote :

A problem with this is instead of the html export using the 'raw' theme's information under /theme/raw/ it actually uses the 'raw' theme information under /export/html/theme/raw/.

So the first step for this would be to refactor how it currently works so that the html export uses resources under /theme/ directory instead. This will cut out some duplication and confusion.

Also it will allow us to check for the resources under a particular theme and then fallback to the 'raw' if the resources are not found. And also allow the export html to incorporte css / image changes easier.

I suspect the template/css/image files under /export/html/theme/raw/ will differ slightly to their main counterparts at the moment. So there will be some merging/renaming of things needed.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

And a similar request for Leap2A: bug #639638

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

A suggestion is to use a separate export stylesheet at bug #739534.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5759

Revision history for this message
Aaron Wells (u-aaronw) wrote :

In an unusual step, this Wishlist item was fixed in the course of resolving the High-priority Bug 1515826.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Filed additional low-priority bug 1518832 about the fact that the html export is now rather large (3MB zipped), even for a completely empty page.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5724
Committed: https://git.mahara.org/mahara/mahara/commit/01f8970947a3325a692fa8c481a9c0d0812680e4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 01f8970947a3325a692fa8c481a9c0d0812680e4
Author: Robert Lyon <email address hidden>
Date: Tue Nov 17 12:13:20 2015 +1300

Bug 739528, Bug 1515826: Adding actual theme css files

And getting them to display in the export html files

behatnotneeded

Change-Id: I881817dfb94d78a1fd2ac8b0e85b3ebed83b42cf
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5759
Committed: https://git.mahara.org/mahara/mahara/commit/30904f504d876248ad14b524b8cb25638e268eab
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 30904f504d876248ad14b524b8cb25638e268eab
Author: Robert Lyon <email address hidden>
Date: Tue Nov 17 12:13:20 2015 +1300

Bug 739528, Bug 1515826: Adding actual theme css files

And getting them to display in the export html files

behatnotneeded

Change-Id: I881817dfb94d78a1fd2ac8b0e85b3ebed83b42cf
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Apparently the HTML exports now have CSS again, but they aren't using the selected theme. They're displaying the "raw" theme again, which was the complaint at the beginning of this issue. So, I'm re-opening it.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

I just tested with the latest master. The export does retain certain qualities from a theme, e.g. main link color, heading font, but definitely not yet everything. It is still a very stripped down stylesheet without the Mahara header etc. Also the base font doesn't seem to be exported properly. I only see Times for regular text.

I don't expect the export to look exactly like what you have on Mahara, but at least have minimal elements styled as well as make the collection navigation more prominent for example.

Aaron Wells (u-aaronw)
no longer affects: mahara/15.10
no longer affects: mahara/16.04
Changed in mahara:
milestone: 16.04.0 → 16.10.0
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.0 → 16.10.1
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.1 → 17.04.0
Changed in mahara:
milestone: 17.04.0 → none
Revision history for this message
Antony Coombs (antonycoombs) wrote :

What is happening with this request? This would be important for us at the University of Sussex.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

We haven't made any changes to the basic theme recently.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9816

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Steven (stevens-q) wrote :

LAUNCHPAD: https://bugs.launchpad.net/mahara/+bug/739528
GERRIT: https://reviews.mahara.org/#/c/9816/3
==============================================

TITLE: Export to HTML doesn't use selected theme

BUG SUMMARY: When a view or views is/are exported, the default "raw" style sheet (theme) is used for display. The export should use the selected theme instead.
==============================================

Commit hash: d01d8a1309bed2d0923468241e0ce4beb5697ac0
Environment tested: Master
Browser tested: Chrome
Theme used: Raw | Primary school

PRECONDITIONS:
------------------------
1) Inst admin exists and belongs to Institution One with Primary school theme (User1)
2) Inst admin (User1) portfolio page exists
3) Inst admin exists and belongs to Institution Two with Site default theme (User2)
4) Inst admin (User2) portfolio page exists

TEST STEPS:
------------------------
1) Log in as Inst admin User1
2) Browse to the Export page
3) Choose an export format = Standalone HTML website
4) Select Just some of my pages
5) Click the "Click to preview" link
6) Verify that the preview uses the Primary school theme
7) Generate the export and save to a local folder
8) Unzip the folder and open the index.html page in a browser
9) Verify that the preview uses the Primary school theme
10) Repeat the above steps using Inst admin (User2)
11) Verify that the preview uses the Site default theme

NOTE: Exports of Leap2a files will not bring across the theme if a users institution has a different theme

Catalyst Qa Approved ✔

Changed in mahara:
milestone: none → 19.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9816
Committed: https://git.mahara.org/mahara/mahara/commit/1e0e655e02b9a177cd6a715a9516cdc324366468
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1e0e655e02b9a177cd6a715a9516cdc324366468
Author: Robert Lyon <email address hidden>
Date: Sat Apr 20 11:48:07 2019 +1200

Bug 739528: Adjust the HTML export template / css

To make it more in line with the current look/feel

behatnotneeded

Change-Id: Ibd5279677f18863b25b4f83f7d6404730aa750e7
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
tags: added: nominatedfeature
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints