Comment 8 for bug 717184

Revision history for this message
Alan McNatty (alanmc) wrote :

Just a comment on the implementation.

It is a shame this was implemented in the view (function pieform_element_filebrowser_upload) and not in the base file artefact class (i.e. ArtefactTypeFile::save_uploaded_file method).

If a user has enabled image resizing then ArtefactTypeFile::save_uploaded_file should resize the image on save automatically. What has been implemented is a Fix to the web-form only - the biggest culprit to uploading oversized images may be mobile devices (as the mobile user often lacks the control to resize the content on the device)

With this implementation the mobile API would need to reinvent the wheel. The endable resize config option does not actual resize all uploaded content.