Clean up the Print stylesheet
Bug #692769 reported by
François Marier
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Robert Lyon |
Bug Description
We should make sure that views have a working print stylesheet.
Changed in mahara: | |
importance: | Medium → Low |
milestone: | 1.4.0 → none |
importance: | Low → Medium |
tags: | added: printing |
Changed in mahara: | |
milestone: | none → 1.7.0 |
Changed in mahara: | |
milestone: | 1.7.0 → 1.8.0 |
summary: |
- Make sure that the print stylesheet still works + [Ongoing] Make sure that the print stylesheet still works |
Changed in mahara: | |
milestone: | 1.8rc1 → 1.8.0 |
Changed in mahara: | |
milestone: | 1.9.0 → 1.10.0 |
Changed in mahara: | |
milestone: | 1.10.0 → none |
Changed in mahara: | |
status: | Triaged → In Progress |
milestone: | none → 17.04.0 |
assignee: | nobody → Robert Lyon (robertl-9) |
tags: | added: nominatedfeature |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed the actual print style sheet to work correctly.
File: theme/raw/ static/ style/print. css (fixed and attached) templates/ header/ head.tpl (if somebody knows how to fix that part, it would be appreciated).
File: theme/raw/
The problem is that the template code (/theme/ raw/templates/ header/ head.tpl) is trying to read the style sheet from only the theme instead of raw and then the theme, if the theme has a print style sheet. I could not figure out how to fix that part, so I only attached the print.css file.
If an end user wants to attach this patch, they will need to temporarily add a hardcoded fixed to the head.tpl file:
Old code in head.tpl: 'style/ print.css' }" media="print"> localhost/ portfolio/ theme/raw/ static/ style/print. css" media="print">
<link rel="stylesheet" type="text/css" href="{theme_url filename=
New code in head.tpl:
<link rel="stylesheet" type="text/css" href="http://
FYI: The print.css file was completely rewritten, so just copy it over, don't try to patch it. This file has not been extensively tested. Tested only on Firefox (current version) using print-preview on a US computer system. Also, only the view, dashboard, collection, and profile were tested. Did not test the printing of other pages.
Related issues:
* What to do about navigation -- Do we need two classes, so the end user can choose if they want their page navigations (page views) to be included or not included)?
* print-page-breaks -- adding the class to the print.css file is done, but how does a user add this to their page? Do we need to add a blocktype called "print-page-break"?
* Do we want to allow the user to add a print MLA at the end of a print page?