Comment 3 for bug 619867

Revision history for this message
Richard Mansfield (richard-mansfield) wrote :

I don't think I agree with either solution really, because if you add some views, and then navigate away without clicking any of the next/cancel/done buttons, you end up with a collection in a state where it has views in it, but all those views have different access rules.

That's a problem with both creating new views and creating new collections -- they're pretending to be a wizards when that's not really what they are (they have 'cancel' buttons down the bottom that aren't really cancel buttons, they're 'delete' buttons).

For views it's not so bad, because a half-created view is pretty harmless - only the owner can see it. With collections you end up with broken links which is worse, and potential upgrade headaches for us later on when we eventually merge access across collections properly in the db.

So I'd prefer to either:

(1) leave it as it is, and add a message to the user to say what access was added every time views are added (admittedly this is still a bit yuck), or

(2) Change the way the page works so that the views are not updated at all until you save the page (by clicking next/save) - then the cancel button really means cancel. We can tell the user at that time what access rules will be added. Stacey, I think you had a half-finished view picker widget that will do this job, right?