check if it's worth it to allow to define async loads in the
get_instance_javascript inside the blocktype classes
for example
array(
'file' => (is_https() ? 'https:' : 'http:') . '//cdn.embedly.com/widgets/platform.js',
'async' => true,
)
we would need to also modify the get_all_blocktype_javascript function
Reviewed: https:/ /reviews. mahara. org/11046 /git.mahara. org/mahara/ mahara/ commit/ 55a849e4dd0606a 42926d848953ae1 adeb80fcdc
Committed: https:/
Submitter: Robert Lyon (<email address hidden>)
Branch: master
commit 55a849e4dd0606a 42926d848953ae1 adeb80fcdc
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jun 29 16:45:24 2020 +1200
Bug 1885460: load platform.js only for external video block
TODO /docs.embed. ly/docs/ platformjs
embedly documentation indicates to do an async load of the file
https:/
check if it's worth it to allow to define async loads in the javascript inside the blocktype classes embedly. com/widgets/ platform. js',
get_instance_
for example
array(
'file' => (is_https() ? 'https:' : 'http:') . '//cdn.
'async' => true,
)
we would need to also modify the get_all_ blocktype_ javascript function
behatnotneeded
Change-Id: I8ff3cd0b867edb ce24c7b2581e6a2 3e88b68ff0c