Missing lang string when saving to timeline

Bug #1832805 reported by Ghada El-Zoghbi on 2019-06-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 19.10
18.10
High
Unassigned
19.04
High
Unassigned
19.10
High
Unassigned

Bug Description

Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF

After a portfolio assignment has been unlocked (i.e. after grading) and was submitted via MNET, a student tries to save the page/collection in timeline, it display an error message.

Which is the correct behaviour.

The issues is a missing language string: [[cantversionview/view]] in the error message that is displayed to the user.

Please see attached image.

Ghada El-Zoghbi (ghada-z) wrote :
Ghada El-Zoghbi (ghada-z) wrote :

Please let me know what the message should say and I can upload a patch.

Ghada El-Zoghbi (ghada-z) wrote :

There are 4 different scenarios:

1. The page id passed to the form is invalid

2. The user does not have permission to edit the page (i.e. they are not the owner for example or it's an institution view and they are not an institution admin/staff).

3. The page has been submitted for assessment.

4. This page is for a group and the editable window dates has passed.

I will create 4 separate lang strings for each scenario.

Reviewed: https://reviews.mahara.org/10089
Committed: https://git.mahara.org/mahara/mahara/commit/1a08674ae5d5fb8a577d1b691aa6d2d235073cf0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1a08674ae5d5fb8a577d1b691aa6d2d235073cf0
Author: Ghada El-Zoghbi <email address hidden>
Date: Mon Jun 17 13:37:03 2019 +1000

Bug 1832805: Add missing lang strings when saving page to timeline

Four new lang strings:
* cantversionviewinvalid
* cantversionvieweditpermissions
* cantversionviewsubmitted
* cantversionviewgroupeditwindow

Have separated the scenarios out for better feedback to the user.

Sponsored by The Australian National University

behatnotneeded

Change-Id: Id4952c37f35631b2f6a1dfad8129bac48108d733

Reviewed: https://reviews.mahara.org/10091
Committed: https://git.mahara.org/mahara/mahara/commit/3cfbd58dffd5d86421b3763161d4270974128b13
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 3cfbd58dffd5d86421b3763161d4270974128b13
Author: Ghada El-Zoghbi <email address hidden>
Date: Mon Jun 17 13:37:03 2019 +1000

Bug 1832805: Add missing lang strings when saving page to timeline

Four new lang strings:
* cantversionviewinvalid
* cantversionvieweditpermissions
* cantversionviewsubmitted
* cantversionviewgroupeditwindow

Have separated the scenarios out for better feedback to the user.

Sponsored by The Australian National University

behatnotneeded

Change-Id: Id4952c37f35631b2f6a1dfad8129bac48108d733
(cherry picked from commit 1a08674ae5d5fb8a577d1b691aa6d2d235073cf0)

Reviewed: https://reviews.mahara.org/10092
Committed: https://git.mahara.org/mahara/mahara/commit/6da035a1b73bb00fb7ea0ab906614600afa14efb
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 6da035a1b73bb00fb7ea0ab906614600afa14efb
Author: Ghada El-Zoghbi <email address hidden>
Date: Mon Jun 17 13:37:03 2019 +1000

Bug 1832805: Add missing lang strings when saving page to timeline

Four new lang strings:
* cantversionviewinvalid
* cantversionvieweditpermissions
* cantversionviewsubmitted
* cantversionviewgroupeditwindow

Have separated the scenarios out for better feedback to the user.

Sponsored by The Australian National University

behatnotneeded

Change-Id: Id4952c37f35631b2f6a1dfad8129bac48108d733
(cherry picked from commit 1a08674ae5d5fb8a577d1b691aa6d2d235073cf0)
(cherry picked from commit 3cfbd58dffd5d86421b3763161d4270974128b13)

Ghada El-Zoghbi (ghada-z) wrote :

A bug was introduced in this fix which does not allow the user to remove an image from the image artefact.

Steps to reproduce:

- Add an image artefact to a page.
- Select an image and save
- Edit the image artefact on the page
- Try to remove the image

Expected result: image should be removed
What actually happens: image does not get removed due to an error in the console.

I'll add a patch.

Ghada El-Zoghbi (ghada-z) wrote :

Sorry... note #10 is on the wrong bug.

Should be bug #1833034

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers