Error/warning/success messages remains unless page is refreshed

[Ghada El-Zoghbi]

Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF and Chrome (and others)

In the Files upload screen (and other screens that display error message):

When a user accidentally clicks on the 'Create folder' icon before entering a folder name, a red error message appears:

"Please provide a name for the new folder."

When the user enters the folder name and clicks the button again, the folder is created but the red error message still appears.

The message is only removed after the user refreshes the page.

This can be misleading to the user.

Can you lease clear the message when the folder is created - and display a success message?

Another scenario:

* The user creates a folder successfully.
* The user then clicks into the new folder
* Clicks the 'Create folder' button (in the child folder) without providing a name
* The error message then appears
* Clicks the up arrow to go to the parent folder.
* The error message still appears - even though the user has moved out of the child folder.

Expected, the error message should clear.

Ideally, all alert messages in danger, warning, success classes should fade out after perhaps 10 seconds? This should be throughout the entire site not just the above screens.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10090
Committed: https://git.mahara.org/mahara/mahara/commit/e69b8a8546e57fd7c499350574e022bb34e200f1
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e69b8a8546e57fd7c499350574e022bb34e200f1
Author: Robert Lyon <email address hidden>
Date: Mon Jun 17 17:31:58 2019 +1200

Bug 1833034: Allow folder fail message be removed on success

And show a success message

Also remove metadata edit error message on form resubmit rather than
appending the same message again

behatnotneeded

Change-Id: I31f99a6ca384b74ca3e2ea795055667811f58e0a
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10110

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10110
Committed: https://git.mahara.org/mahara/mahara/commit/d05113f59537cdaee39b1d0aa89a13a96015d847
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit d05113f59537cdaee39b1d0aa89a13a96015d847
Author: Robert Lyon <email address hidden>
Date: Mon Jun 17 17:31:58 2019 +1200

Bug 1833034: Allow folder fail message be removed on success

And show a success message

Also remove metadata edit error message on form resubmit rather than
appending the same message again

behatnotneeded

Change-Id: I31f99a6ca384b74ca3e2ea795055667811f58e0a
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit e69b8a8546e57fd7c499350574e022bb34e200f1)

[Ghada El-Zoghbi (ghada-z)]

A bug was introduced in this fix which does not allow the user to remove an image from the image artefact.

Steps to reproduce:

- Add an image artefact to a page.
- Select an image and save
- Edit the image artefact on the page
- Try to remove the image

Expected result: image should be removed
What actually happens: image does not get removed due to an error in the console.

I'll add a patch.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10135

[Steven (stevens-q)]

Commit hash: 4a30239dea1cda0acf851877e97701c3ed52b569
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Mahara User exists

TEST STEPS Part 1: Error/warning/success messages remains unless page is refreshed
------------------------
1) User log in as Site admin
2) Browse to the files upload page http://mahara.stevens-lp.dynamic.wgtn.cat-it.co.nz/artefact/file/index.php
3) Click the Create new folder button (Without entering a name in the field)
4) Verify that an error message is dispayed ✔
5) Enter a name in the field and click the Create new folder button
6) Verify that the error message disappears ✔

TEST STEPS Part 2: - user cannot remove an image from the image artefact.
------------------------
1) User create a portfolio page
2) Add an image block to the page
3) Verify that the image is displayed on the page
4) Edit the image block and remove the image and save
5) Verify that the Image is removed

NOTE - no issues found with deleting images or changing to different images

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10135
Committed: https://git.mahara.org/mahara/mahara/commit/af07e62f215e729af03635796ce45294997f00ea
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit af07e62f215e729af03635796ce45294997f00ea
Author: Ghada El-Zoghbi <email address hidden>
Date: Thu Jun 27 10:25:26 2019 +1000

Bug 1833034: fix error when removing an image

Sponsored by The Australian National University

behatnotneeded

Change-Id: If92710cc6c48d7f185f094ab84e2a6e136bfcfc0

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10147

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10147
Committed: https://git.mahara.org/mahara/mahara/commit/07b3610fe106940627f02932746a973c3805f872
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 07b3610fe106940627f02932746a973c3805f872
Author: Ghada El-Zoghbi <email address hidden>
Date: Thu Jun 27 10:25:26 2019 +1000

Bug 1833034: fix error when removing an image

Sponsored by The Australian National University

behatnotneeded

Change-Id: If92710cc6c48d7f185f094ab84e2a6e136bfcfc0
(cherry picked from commit af07e62f215e729af03635796ce45294997f00ea)