Cannot toggle Group's Open button

[Ghada El-Zoghbi]

Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: Firefox

* Prerequiste: create an institution (Inst1) other than Mahara.

* Created a group with the following settings:

Group name = 1904 Upgrade Test G2
Associate with Institution = Inst1
Group homepage URL = 1904-upgrade-test-g2
Open = No
Controlled = Yes
Request = Yes
Roles: Course: Member, Tutor, Admin
Friend Invitations: No
Recommendations = No
Create and edit = All group members
Allow submissions = Yes
Allow archiving of submissions = Yes
Publicly viewable group = Yes
Hide group = No
Hide membership = Hide members
Hide membership from members = No
Participation report = Yes
Auto-add users = No
Shared page notifications = All group members
Comment notifications = All group members
Send forum posts immediately = Yes

* Save the group settings.

* Come back into the group settings page, the Open button is disabled - i.e. click on Controlled = No - should toggle the Open button on.

Current Behaviour: Open button remains disabled
Expected Behavious: Open button should be enabled.

This will need to be tested with isolated institutions turned on and turned off. Isolation should not force the "open" option to be unavailable as only site admins can set up public groups when isolation is turned on and they can decide whether the group is to be open or not.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10077

[Steven (stevens-q)]

BUG SUMMARY: Create a closed Group then go back and change to open group - tested with isolated institutions turned on and turned off.

==============================================

Commit hash: 53d7eb7a458d7613eac1edf2ffa328fa44c0113c
Environment tested: Master
Browser tested: Chrome
Theme used: Raw | Default raw | Ocean | Modern | Primary school

PRECONDITIONS:
------------------------
1) $cfg->isolatedinstitutions = true; has been added to the config.php file
2) Institution exists (Institution One)

TEST STEPS:
------------------------
1) Log in as Site admin
2) Created a group with the following settings:
• Group name = 1904 Upgrade Test G2
• Associate with Institution = Inst1
• Group homepage URL = 1904-upgrade-test-g2
• Open = No
• Controlled = Yes
• Request = Yes
• Roles: Course: Member, Tutor, Admin
• Friend Invitations: No
• Recommendations = No
• Create and edit = All group members
• Allow submissions = Yes
• Allow archiving of submissions = Yes
• Publicly viewable group = Yes
• Hide group = No
• Hide membership = Hide members
• Hide membership from members = No
• Participation report = Yes
• Auto-add users = No
• Shared page notifications = All group members
• Comment notifications = All group members
• Send forum posts immediately = Yes
3) Save the group settings.
4) Come back into the group settings page
5) Verify the Open button is enabled and user can click the button to toggle it to yes and no ✔
6) Click the button to Yes
7) Verify that the "Request" is switched to "No" and is disabled ✔

NOTE: Run the above script with code line - $cfg->isolatedinstitutions = false; added to the config.php file

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10077
Committed: https://git.mahara.org/mahara/mahara/commit/53d7eb7a458d7613eac1edf2ffa328fa44c0113c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 53d7eb7a458d7613eac1edf2ffa328fa44c0113c
Author: Ghada El-Zoghbi <email address hidden>
Date: Thu Jun 13 16:31:22 2019 +1000

Bug 1832308: Group setting and isolated institutions

The public setting on a group should not affect
the jointype.

Bring back original 18.10 functionality for
group settings page by:
* Removing the friends customisation.
* Removing affect of Public setting on other toggles.

Bring back original 18.10 functionality for who
can join a group:
* Users will be able to join the group on their own -
if it is open - regardless of the isolatedinstitutions
and public settings.

Please note for isolatedinstitutions:
Only site admins can create public groups.
It is up to the site admin to add users to groups
if they are set to public.
It is also up to the site admin to correctly set the jointype
for the group.
Therefore, for open groups, users can join the
group if it's in their institution.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I0901f1ddf3b1c982dab0b3f4725755b6b0cdf5f2

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10120

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10120
Committed: https://git.mahara.org/mahara/mahara/commit/8f1eeb1235ce8fe1a21ba046295538a23097d445
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 8f1eeb1235ce8fe1a21ba046295538a23097d445
Author: Ghada El-Zoghbi <email address hidden>
Date: Thu Jun 13 16:31:22 2019 +1000

Bug 1832308: Group setting and isolated institutions

The public setting on a group should not affect
the jointype.

Bring back original 18.10 functionality for
group settings page by:
* Removing the friends customisation.
* Removing affect of Public setting on other toggles.

Bring back original 18.10 functionality for who
can join a group:
* Users will be able to join the group on their own -
if it is open - regardless of the isolatedinstitutions
and public settings.

Please note for isolatedinstitutions:
Only site admins can create public groups.
It is up to the site admin to add users to groups
if they are set to public.
It is also up to the site admin to correctly set the jointype
for the group.
Therefore, for open groups, users can join the
group if it's in their institution.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I0901f1ddf3b1c982dab0b3f4725755b6b0cdf5f2
(cherry picked from commit 53d7eb7a458d7613eac1edf2ffa328fa44c0113c)