Comment 5 for bug 1832308

Reviewed: https://reviews.mahara.org/10120
Committed: https://git.mahara.org/mahara/mahara/commit/8f1eeb1235ce8fe1a21ba046295538a23097d445
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 8f1eeb1235ce8fe1a21ba046295538a23097d445
Author: Ghada El-Zoghbi <email address hidden>
Date: Thu Jun 13 16:31:22 2019 +1000

Bug 1832308: Group setting and isolated institutions

The public setting on a group should not affect
the jointype.

Bring back original 18.10 functionality for
group settings page by:
* Removing the friends customisation.
* Removing affect of Public setting on other toggles.

Bring back original 18.10 functionality for who
can join a group:
* Users will be able to join the group on their own -
if it is open - regardless of the isolatedinstitutions
and public settings.

Please note for isolatedinstitutions:
Only site admins can create public groups.
It is up to the site admin to add users to groups
if they are set to public.
It is also up to the site admin to correctly set the jointype
for the group.
Therefore, for open groups, users can join the
group if it's in their institution.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I0901f1ddf3b1c982dab0b3f4725755b6b0cdf5f2
(cherry picked from commit 53d7eb7a458d7613eac1edf2ffa328fa44c0113c)