Paginator is missing styling in forum topic

[Kristina Hoeppner]

When you are in a forum topic, the paginator does not display the correct styling (see screenshot) when there are 11+ forum posts in a forum topic.

To replicate:

1. Create a group.
2. Create a topic in a forum with 10 replies to the topic so that the paginator at the bottom is displayed.

Expected result: The paginator looks like it does everywhere.
Actual result: Only the text is shown, but not the outline around it and the appropriate spacing.

This should be checked in all themes to ensure the paginator is displayed correctly.

[Kristina Hoeppner (kris-hoeppner)]

This is also happening on /view/choosetemplate.php?searchcollection=1 , i.e. Main menu -> Create -> Pages and collections -> Click the "Copy" button.

[Kristina Hoeppner (kris-hoeppner)]

https://reviews.mahara.org/9814

[Robert Lyon (robertl-9)]

Some places where we have a paginator without a jsonscript / js option

htdocs/artefact/internal/lib.php line 1276 (for social profiles)
htdocs/skin/index.php
htdocs/admin/site/skins.php
htdocs/interaction/forum/view.php
htdocs/interaction/forum/topic.php
htdocs/webservice/admin/webservicessearchlib.php
htdocs/view/choosetemplate.php

[Kristina Hoeppner (kris-hoeppner)]

Seen during testing on /forum/view.php: The topics should sit right-aligned (see https://mahara.org/interaction/forum/view.php?id=1 )

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9814
Committed: https://git.mahara.org/mahara/mahara/commit/66a6ede8392e942e88141622fe5f422f19057249
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 66a6ede8392e942e88141622fe5f422f19057249
Author: Robert Lyon <email address hidden>
Date: Sun Apr 21 11:59:06 2019 +1200

Bug 1825599: Adding the pagination link styles via PHP

We used to add them via js but some pagination instances do not use
json update and so were not getting styled

behatnotneeded

Change-Id: Ibc225c34a730c8b14ea35a529ad4d350aa33fd56
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9860

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9860
Committed: https://git.mahara.org/mahara/mahara/commit/728abce996e056d6705a56ab6c777c57dff749d1
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 728abce996e056d6705a56ab6c777c57dff749d1
Author: Robert Lyon <email address hidden>
Date: Sun Apr 21 11:59:06 2019 +1200

Bug 1825599: Adding the pagination link styles via PHP

We used to add them via js but some pagination instances do not use
json update and so were not getting styled

behatnotneeded

Change-Id: Ibc225c34a730c8b14ea35a529ad4d350aa33fd56
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 66a6ede8392e942e88141622fe5f422f19057249)