Comment 16 for bug 1756904

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

As we discussed, there are 2 ways we to resolve this
1. Translate the filenames to be included in the export, removing all symbols that could be consider invalid chars in the os.
This is not easy as replacing the symbols, since we could have similar names that translate to the same name, so we would have to keep track of all the names taken and find a way to choose a new one in case is not available.

2. Do not allow invalid chars in windows and linux to be part of mahara filenames either.
But we have to consider the files that already exist in mahara.
If we want to rename them to remove the invalid chars, then we have the same problem as above, and some users might not like to see their files renamed or they could think there's something wrong with them.

The patch I had started here https://reviews.mahara.org/#/c/8798/ follows solution 1, but I'd like to know what's the best solution before I abandon or continue working on it.