Can't click the "Comments" link in a retractable block

Bug #1690232 reported by Kristina Hoeppner on 2017-05-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
16.04
High
Unassigned
16.10
High
Unassigned
17.04
High
Unassigned
17.10
High
Unassigned

Bug Description

Mahara 16.04+

You can't click on "Comments" in a retractable block. It just loads the page again but doesn't open the modal. It works fine when the block is not retracted.

To replicate:

1. Create a page with a block that can have comments, e.g. "Note".
2. Set the page to auto-retract
3. View the page, add a comment and go back to the page.
4. Click the "Comments" button.

Expected result: The comments modal pops in.
Actual result: Nothing happens.

When you test it, also make sure to test all retractable settings: No, Yes, auto-retract.

Robert Lyon (robertl-9) wrote :

The problem here is that when a block has retractable set, whether fully retracted or can retract, and we click the comments link it fires both the open dock.show() option and close dock.hide() option straight away

I suspect something with the retractable code is causing this

Reviewed: https://reviews.mahara.org/7759
Committed: https://git.mahara.org/mahara/mahara/commit/5ce66781dfa1bd23f1bb632b9e61e68677259358
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5ce66781dfa1bd23f1bb632b9e61e68677259358
Author: Robert Lyon <email address hidden>
Date: Sun May 14 16:09:28 2017 +1200

Bug 1690232: Comments link on retractable block failing to open modal

Actually the modal is opening and closing in the same instant.

This is caused by some code dealing with collapsible blocks making
sure modals are closed if outside certain rules.

This change checks what modal we are wanting and closing all but the
one are targeting when clicking the 'comments' link

behatnotneeded

Sponsored by SWITCH

Change-Id: Idb5165bdc8349f77286aa776ff75d152968aefda
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/7780
Committed: https://git.mahara.org/mahara/mahara/commit/b2858fcf96d80809b8a9d6af4a85a9fc8d7fc392
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit b2858fcf96d80809b8a9d6af4a85a9fc8d7fc392
Author: Robert Lyon <email address hidden>
Date: Sun May 14 16:09:28 2017 +1200

Bug 1690232: Comments link on retractable block failing to open modal

Actually the modal is opening and closing in the same instant.

This is caused by some code dealing with collapsible blocks making
sure modals are closed if outside certain rules.

This change checks what modal we are wanting and closing all but the
one are targeting when clicking the 'comments' link

behatnotneeded

Sponsored by SWITCH

Change-Id: Idb5165bdc8349f77286aa776ff75d152968aefda
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5ce66781dfa1bd23f1bb632b9e61e68677259358)

Mahara Bot (dev-mahara) wrote :

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7782

Reviewed: https://reviews.mahara.org/7782
Committed: https://git.mahara.org/mahara/mahara/commit/a4577946c3d7b8a62aafcbc3c8cf4d5f91e7cc78
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit a4577946c3d7b8a62aafcbc3c8cf4d5f91e7cc78
Author: Robert Lyon <email address hidden>
Date: Sun May 14 16:09:28 2017 +1200

Bug 1690232: Comments link on retractable block failing to open modal

Actually the modal is opening and closing in the same instant.

This is caused by some code dealing with collapsible blocks making
sure modals are closed if outside certain rules.

This change checks what modal we are wanting and closing all but the
one are targeting when clicking the 'comments' link

behatnotneeded

Sponsored by SWITCH

Change-Id: Idb5165bdc8349f77286aa776ff75d152968aefda
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5ce66781dfa1bd23f1bb632b9e61e68677259358)
(cherry picked from commit b2858fcf96d80809b8a9d6af4a85a9fc8d7fc392)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7781
Committed: https://git.mahara.org/mahara/mahara/commit/84a76f608d089e2cf1de395eda1d17a7a77ce4b6
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 84a76f608d089e2cf1de395eda1d17a7a77ce4b6
Author: Robert Lyon <email address hidden>
Date: Sun May 14 16:09:28 2017 +1200

Bug 1690232: Comments link on retractable block failing to open modal

Actually the modal is opening and closing in the same instant.

This is caused by some code dealing with collapsible blocks making
sure modals are closed if outside certain rules.

This change checks what modal we are wanting and closing all but the
one are targeting when clicking the 'comments' link

behatnotneeded

Sponsored by SWITCH

Change-Id: Idb5165bdc8349f77286aa776ff75d152968aefda
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5ce66781dfa1bd23f1bb632b9e61e68677259358)
(cherry picked from commit b2858fcf96d80809b8a9d6af4a85a9fc8d7fc392)

Reviewed: https://reviews.mahara.org/8094
Committed: https://git.mahara.org/mahara/mahara/commit/70ac7cec17e778da31d928ea37a7e2c7de13459f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 70ac7cec17e778da31d928ea37a7e2c7de13459f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Oct 5 17:06:05 2017 +1300

Bug 1720269: old_raw patches for bugs: (General)

Bug 1720264
Bug 1720235
Bug 1719736
Bug 1718821
Bug 1705126
Bug 1694908
Bug 1690687
Bug 1690232
Bug 1686843
Bug 1685041
Bug 1683561
Bug 1681987
Bug 1681934
Bug 1675223
Bug 1636064
Bug 1575512
Bug 1369569
Bug 692769

Also fixing up un-closed html tags in Bug 1701437 for raw and old raw

behatnotneeded

Change-Id: I8ac930ceebf78b4edad97289994318e7689a1e94

Reviewed: https://reviews.mahara.org/8116
Committed: https://git.mahara.org/mahara/mahara/commit/a25f4f11d35bf17d54acfb8010cd29e432fc86ea
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit a25f4f11d35bf17d54acfb8010cd29e432fc86ea
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Oct 5 17:06:05 2017 +1300

Bug 1720269: old_raw patches for bugs: (General)

Bug 1720264
Bug 1720235
Bug 1719736
Bug 1718821
Bug 1705126
Bug 1694908
Bug 1690687
Bug 1690232
Bug 1686843
Bug 1685041
Bug 1683561
Bug 1681987
Bug 1681934
Bug 1675223
Bug 1636064
Bug 1575512
Bug 1369569
Bug 692769

Also fixing up un-closed html tags in Bug 1701437 for raw and old raw

behatnotneeded

Change-Id: I8ac930ceebf78b4edad97289994318e7689a1e94
(cherry picked from commit 70ac7cec17e778da31d928ea37a7e2c7de13459f)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers