Comment 2 for bug 1689312

Revision history for this message
Kevin Dibble (digitalskill) wrote :

Really not sure which is the best solution.
1.) Force LDAP not to have spaces - which would break current installs.
2.) Add a special character in the username feature (Like Moodle) which existing users of Mahara will need to know before updating.
or
3.) leave (not really broken - more of a data checking/ entry issue?)

LDAP usernames can contain spaces.
Putting in a trim feature would then break all existing users on Mahara where their LDAP has been set up to allow spaces. So - allowing spaces in LDAP username looks to be allowed for this very reason.

Moodle put in this solution:
$CFG->extendedusernamechars = true
To allow special characters in usernames (Which old LDAPS out there use).
https://moodle.org/mod/forum/discuss.php?d=279500

As Mahara allows special characters once you choose LDAP - it already resolves a Moodle issue.