Bug 1605127: Method signature mismatch in Activity::update_url()
The abstract Activity class defines the function update_url()
with no parameters, but the two subclasses that override it
define it with one parameter. This will cause problems in PHP 7.
It's always called with one parameter, (even in the Activity
class itself) so the best option is to add one parameter to the
implementation in Activity.
Change-Id: I810061ed6f8c55101327e2e907bb68ebf9870380
behatnotneeded: Covered by existing tests
Reviewed: https:/ /reviews. mahara. org/6744 /git.mahara. org/mahara/ mahara/ commit/ b469030b12e8014 7d406fc00b75afe 024a329402
Committed: https:/
Submitter: Robert Lyon (<email address hidden>)
Branch: master
commit b469030b12e8014 7d406fc00b75afe 024a329402
Author: Aaron Wells <email address hidden>
Date: Mon Jul 25 10:56:35 2016 +1200
Bug 1605127: Method signature mismatch in Activity: :update_ url()
The abstract Activity class defines the function update_url()
with no parameters, but the two subclasses that override it
define it with one parameter. This will cause problems in PHP 7.
It's always called with one parameter, (even in the Activity
class itself) so the best option is to add one parameter to the
implementation in Activity.
Change-Id: I810061ed6f8c55 101327e2e907bb6 8ebf9870380
behatnotneeded: Covered by existing tests