PHP7 compatibility problems with function parameters
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Mahara |
Medium
|
Unassigned | ||
| 1.10 |
Medium
|
Unassigned | ||
| 15.04 |
Medium
|
Unassigned | ||
| 15.10 |
Medium
|
Unassigned | ||
| 16.04 |
Medium
|
Unassigned | ||
| 16.10 |
Medium
|
Unassigned |
Bug Description
PHP 7 causes warnings about parameter TypeError
We need to clean up some code to be consistent.
Reviewed: https:/
Committed: https:/
Submitter: Aaron Wells (<email address hidden>)
Branch: master
commit c5eb6088ccdd6fa
Author: Robert Lyon <email address hidden>
Date: Thu Apr 28 10:40:39 2016 +1200
Bug 1575955: fixing function signatures for PHP7
They need to be consistent in PHP7 and include the parameter types.
behatnotneeded - existing tests are ok
Change-Id: I5d94ee53962a92
Signed-off-by: Robert Lyon <email address hidden>
Patch for "16.04_STABLE" branch: https:/
Reviewed: https:/
Committed: https:/
Submitter: Aaron Wells (<email address hidden>)
Branch: 16.04_STABLE
commit 67858c0077897d6
Author: Robert Lyon <email address hidden>
Date: Thu Apr 28 10:40:39 2016 +1200
Bug 1575955: fixing function signatures for PHP7
They need to be consistent in PHP7 and include the parameter types.
behatnotneeded - existing tests are ok
Change-Id: I5d94ee53962a92
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c5eb6088ccdd6fa
Patch for "15.10_STABLE" branch: https:/
Mahara Bot (dev-mahara) wrote : | #6 |
Patch for "15.04_STABLE" branch: https:/
Mahara Bot (dev-mahara) wrote : | #7 |
Patch for "1.10_STABLE" branch: https:/
Reviewed: https:/
Committed: https:/
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.10_STABLE
commit c7106c83b78fc71
Author: Robert Lyon <email address hidden>
Date: Thu Apr 28 10:40:39 2016 +1200
Bug 1575955: fixing function signatures for PHP7
They need to be consistent in PHP7 and include the parameter types.
behatnotneeded - existing tests are ok
Change-Id: I5d94ee53962a92
Signed-off-by: Robert Lyon <email address hidden>
Mahara Bot (dev-mahara) wrote : | #9 |
Reviewed: https:/
Committed: https:/
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE
commit ad873b1e7e93a35
Author: Robert Lyon <email address hidden>
Date: Thu Apr 28 10:40:39 2016 +1200
Bug 1575955: fixing function signatures for PHP7
They need to be consistent in PHP7 and include the parameter types.
behatnotneeded - existing tests are ok
Change-Id: I5d94ee53962a92
Signed-off-by: Robert Lyon <email address hidden>
Mahara Bot (dev-mahara) wrote : | #10 |
Reviewed: https:/
Committed: https:/
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE
commit 97a769a2fbd6158
Author: Robert Lyon <email address hidden>
Date: Thu Apr 28 10:40:39 2016 +1200
Bug 1575955: fixing function signatures for PHP7
They need to be consistent in PHP7 and include the parameter types.
behatnotneeded - existing tests are ok
Change-Id: I5d94ee53962a92
Signed-off-by: Robert Lyon <email address hidden>
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Patch for "master" branch: https:/ /reviews. mahara. org/6408