Mahara

PHP7 compatibility problems with function parameters

Bug #1575955 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
Mahara 16.04.0
1.10
Fix Released
Medium
Unassigned
Mahara 1.10.10
15.04
Fix Released
Medium
Unassigned
Mahara 15.04.7
15.10
Fix Released
Medium
Unassigned
Mahara 15.10.3
16.04
Fix Released
Medium
Unassigned
Mahara 16.04.0
16.10
Fix Released
Medium
Unassigned
Mahara 16.10.0

Bug Description

PHP 7 causes warnings about parameter TypeError

We need to clean up some code to be consistent.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6408

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6408
Committed: https://git.mahara.org/mahara/mahara/commit/c5eb6088ccdd6fa8bf3c67e0fdb8e5997dabbfc0
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit c5eb6088ccdd6fa8bf3c67e0fdb8e5997dabbfc0
Author: Robert Lyon <email address hidden>
Date: Thu Apr 28 10:40:39 2016 +1200

Bug 1575955: fixing function signatures for PHP7

They need to be consistent in PHP7 and include the parameter types.

behatnotneeded - existing tests are ok

Change-Id: I5d94ee53962a92db6faf3718e5a54f48ea31e367
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6437

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6437
Committed: https://git.mahara.org/mahara/mahara/commit/67858c0077897d64b37fbf307ecccf6fc4eb6f00
Submitter: Aaron Wells (<email address hidden>)
Branch: 16.04_STABLE

commit 67858c0077897d64b37fbf307ecccf6fc4eb6f00
Author: Robert Lyon <email address hidden>
Date: Thu Apr 28 10:40:39 2016 +1200

Bug 1575955: fixing function signatures for PHP7

They need to be consistent in PHP7 and include the parameter types.

behatnotneeded - existing tests are ok

Change-Id: I5d94ee53962a92db6faf3718e5a54f48ea31e367
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c5eb6088ccdd6fa8bf3c67e0fdb8e5997dabbfc0)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6447

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6448

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/6449

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6449
Committed: https://git.mahara.org/mahara/mahara/commit/c7106c83b78fc71c43c588d078f71b39cd8ad0db
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.10_STABLE

commit c7106c83b78fc71c43c588d078f71b39cd8ad0db
Author: Robert Lyon <email address hidden>
Date: Thu Apr 28 10:40:39 2016 +1200

Bug 1575955: fixing function signatures for PHP7

They need to be consistent in PHP7 and include the parameter types.

behatnotneeded - existing tests are ok

Change-Id: I5d94ee53962a92db6faf3718e5a54f48ea31e367
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6447
Committed: https://git.mahara.org/mahara/mahara/commit/ad873b1e7e93a35509d76958e049aaf7323f594d
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit ad873b1e7e93a35509d76958e049aaf7323f594d
Author: Robert Lyon <email address hidden>
Date: Thu Apr 28 10:40:39 2016 +1200

Bug 1575955: fixing function signatures for PHP7

They need to be consistent in PHP7 and include the parameter types.

behatnotneeded - existing tests are ok

Change-Id: I5d94ee53962a92db6faf3718e5a54f48ea31e367
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6448
Committed: https://git.mahara.org/mahara/mahara/commit/97a769a2fbd615877336c242a7d97618fe56594a
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 97a769a2fbd615877336c242a7d97618fe56594a
Author: Robert Lyon <email address hidden>
Date: Thu Apr 28 10:40:39 2016 +1200

Bug 1575955: fixing function signatures for PHP7

They need to be consistent in PHP7 and include the parameter types.

behatnotneeded - existing tests are ok

Change-Id: I5d94ee53962a92db6faf3718e5a54f48ea31e367
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.