Refactor $CFG->siteclosed to $CFG->siteclosedforupgrade
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Low
|
Aaron Wells |
Bug Description
Every time I look at init.php I get confused about what the difference is between "siteclosed" and "siteclosedbyadmin" and the various $siteclosedforu
Here's how it actually works:
1. $CFG->siteclose
2. $CFG->siteclosed is set by Mahara itself, if it detects that there is a database upgrade ready to be deployed. It should *not* be manipulated by users, in normal circumstances.
I think it would make things clearer for future developers, if we renamed "siteclosed" to "siteautoclosed
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Hm... actually maybe "siteclosedbyup grade" would be better. It's shorter but still indicates why this was closed, and that it was closed automatically.