© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
I ran the Behat tests again, with the destructors changed to throw an exception if there were uncommitted changes.
No problems at all. So, I think we should be fairly safe getting rid of them.
However, rather than just deleting them, I'm first going to look into whether there's a safe way to make them log a warning or something if there are uncommitted changes. The tricky part there is that I'll need to see what kinds of things are safe to do during which states of garbage collection. For instance, I can't use the standard mahara log_warn() message or anything like that, because it depends on Mahara's global $SESSION variable, which may no longer be present by that point.