Comment 6 for bug 1465107

Revision history for this message
Gilles-Philippe Leblanc (gilles-philippe-leblanc) wrote :

Hi just found that the following fix broke the image license:
https://github.com/MaharaProject/mahara/commit/75f77523122c1394cd0d154f8c9a23522c2422ba

That will not work if we keep the file extension.

The following task was created to address the correct use of the get_image_url method in this context:
https://bugs.launchpad.net/mahara/+bug/1444461

Also, the following fix broke some remaining get_themeurl call:
https://github.com/MaharaProject/mahara/commit/74b5a5e0a5989670a48199413fb646a72170bc95#diff-109

in the file artefact/file/js, there is two remaining call of the get_themeurl() method that cannot work right now because there is no config.theme value inserted.

Maybe we should convert them in the font awesome spinner icon.

The call of SVG file in Javascript was reported here:
https://bugs.launchpad.net/mahara/+bug/1436854