Broken sql queries post adodb upgrade

Bug #1401324 reported by Robert Lyon on 2014-12-11
28
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned

Bug Description

Now that we have upgraded ADODB it is being more strict on certain things

This bug is for fixing those issues - when we find them

Robert Lyon (robertl-9) wrote :

A couple of places where things need fixing:

1) api/xmlrpc/lib.php
2) webservices/admin/index.php

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/4079

Reviewed: https://reviews.mahara.org/4078
Committed: http://gitorious.org/mahara/mahara/commit/6901d16ac19e036f51e53efcd08a9b408623ff84
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 6901d16ac19e036f51e53efcd08a9b408623ff84
Author: Robert Lyon <email address hidden>
Date: Thu Dec 11 13:04:00 2014 +1300

Fixing sql queries post adodb upgrade (Bug #1401324)

We can't pass anything other than an array or null to
get_recordset_sql()

Change-Id: I62717401d3f4960f0e5a5fc76bf8156b0853b9fc
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/4080
Committed: http://gitorious.org/mahara/mahara/commit/a282203c2f939cc2306211329842b863aa5441fd
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a282203c2f939cc2306211329842b863aa5441fd
Author: Aaron Wells <email address hidden>
Date: Thu Dec 11 16:12:36 2014 +1300

Fix incorrect scalar $values param

Bug 1401324

Change-Id: I82cc854004937161c29d74a6c26fc6a00352470b

Son Nguyen (ngson2000) wrote :

One more issue reported by Jinelle:

- Get error messages on Administration -> Institutions -> Admin notifications page

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/4134

Reviewed: https://reviews.mahara.org/4117
Committed: http://gitorious.org/mahara/mahara/commit/c93866f51306481d2c58636c817f89d9dbc6c7de
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c93866f51306481d2c58636c817f89d9dbc6c7de
Author: Son Nguyen <email address hidden>
Date: Tue Dec 30 11:26:53 2014 +1300

Fix incorrect scalar values param in get_records_sql_array() calls

Bug 1401324

Make sure 263 calls of the functions are valid

Change-Id: I791c14969b20ea1c7dff03cc092db9ff79f37a3a
Signed-off-by: Son Nguyen <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4134
Committed: http://gitorious.org/mahara/mahara/commit/f0973c63f8b7d7bba5f087a2991938a57c0b96a5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f0973c63f8b7d7bba5f087a2991938a57c0b96a5
Author: Aaron Wells <email address hidden>
Date: Fri Jan 9 16:15:41 2015 +1300

Allow default null $value in get_records_* methods

Bug 1401324: Since both these methods pass through to
get_recordset_sql(), which accepts a null $value, we should
allow these to accept a null $value as well

Change-Id: Ic1abf516f9a03e05f848d395e7635d458802ba9c

Robert Lyon (robertl-9) wrote :

We seemed to have got the most obvious problems sorted out now.

If there are any new places where the adodb upgrade breaks sql queries then we shall file them as separate bugs

Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers