Mahara

  1. Bug #1394330
  2. Comment #2

Comment 2 for bug 1394330

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3994
Committed: http://gitorious.org/mahara/mahara/commit/3743dcf68d1058f647081cf5d29662181978fd01
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 3743dcf68d1058f647081cf5d29662181978fd01
Author: Robert Lyon <email address hidden>
Date: Thu Nov 20 09:04:00 2014 +1300

Always specify what base type we want returned from parseInt()

Bug 1394330

In most places in mahara we specify that we want base 10 number
returned (or base 16 in case of a hexidecimal css colour)

But there are a few places where we don't specify the radix at all

It's best practice to always include the radix because for older
browsers it interprets leading 0 as octal by default.

Also makes it clearer to developers what type of number is expected to
be retrieved from the string.

Change-Id: Iaecc85cbed875f85b313188c4e96cc1b77c77b31
Signed-off-by: Robert Lyon <email address hidden>