Right, so although this problem has (in theory) existed for artefact and interaction plugins for a while, none of the artefact or interaction plugins in core, includes any top-level menu items, and so the problem hasn't displayed itself.
However, since modules are meant to be more generic, they should be able to add top-level menu items. So we do need to fix this for modules, and we may as well fix it for artefacts and interactions as well.
So I agree, probably the best thing is to create a second method specifically for the right nav menu items. We'll have to consider whether that will break backwards-compatibility for any existing plugins, though. (i.e. are any existing plugins passing back right-nav menu items in their menu_items() function?)
Right, so although this problem has (in theory) existed for artefact and interaction plugins for a while, none of the artefact or interaction plugins in core, includes any top-level menu items, and so the problem hasn't displayed itself.
However, since modules are meant to be more generic, they should be able to add top-level menu items. So we do need to fix this for modules, and we may as well fix it for artefacts and interactions as well.
So I agree, probably the best thing is to create a second method specifically for the right nav menu items. We'll have to consider whether that will break backwards- compatibility for any existing plugins, though. (i.e. are any existing plugins passing back right-nav menu items in their menu_items() function?)