Mahara

  1. Bug #1364229
  2. Comment #1

Comment 1 for bug 1364229

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3611
Committed: http://gitorious.org/mahara/mahara/commit/e5a0f676901c36d489d8b7d8fde9f3c972ce1e48
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e5a0f676901c36d489d8b7d8fde9f3c972ce1e48
Author: Nigel Cunningham <email address hidden>
Date: Mon Jul 28 12:03:08 2014 +1000

(Bug1364229) Upload CSV email addr and username cache optimisation.

This patch optimises the validation function by getting a list
of known email addresses and usernames prior to entering the
validation loop.

Test runs with 2000 preexisting users using XHProf showed a
reduction in execution time from 6.5 seconds to 3.8 seconds,
with an increase in memory use of approximately 1.3MB.

Change-Id: I099f1e3b7d459538b79b78afce271f582ec4a24c
Signed-off-by: Nigel Cunningham <email address hidden>