Okay, the problem here is that Jono's code change doesn't support an obscure Pieforms feature that lets a form have multiple submit buttons, each of which gets its own submit function.
If you create a form with multiple submit buttons, and you create a function called {$formname}_submit_{$buttonname}(), then that function will be called by pieforms if the user clicks that button. This is used on exactly two forms: The profile picture picker, and the admin/users/suspended.php form for unsuspended, unexpiring, or deleting a user.
Notably, neither of these forms has a {$formname}_submit() method. And the way Pieforms is written, it's supposed to return after hitting that _submit() function, and if it doesn't return, it gets to the point where it displays this error message.
So probably the solution here, is that if it goes to a button submit function, it Pieforms should return.
Okay, the problem here is that Jono's code change doesn't support an obscure Pieforms feature that lets a form have multiple submit buttons, each of which gets its own submit function.
If you create a form with multiple submit buttons, and you create a function called {$formname} _submit_ {$buttonname} (), then that function will be called by pieforms if the user clicks that button. This is used on exactly two forms: The profile picture picker, and the admin/users/ suspended. php form for unsuspended, unexpiring, or deleting a user.
Notably, neither of these forms has a {$formname} _submit( ) method. And the way Pieforms is written, it's supposed to return after hitting that _submit() function, and if it doesn't return, it gets to the point where it displays this error message.
So probably the solution here, is that if it goes to a button submit function, it Pieforms should return.