Comment 3 for bug 1255378

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2753
Committed: http://gitorious.org/mahara/mahara/commit/3385efa8a822069c3a5c10e2586c7db872832b2c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3385efa8a822069c3a5c10e2586c7db872832b2c
Author: Aaron Wells <email address hidden>
Date: Wed Nov 27 15:14:41 2013 +1300

Fill in the missing implementation for find_key_name()

Bug #1255378

This fundamentally changes the behavior of find_key_name(). Before, it only generated what the default name for the key would be, now it actually checks whether a key of that description exists in the DB and returns its actual name in the DB.

In core the method was only used by XMLDBGenerator in the methods for dropping or altering a key, so this change will actually make it more robust.

In theory, though, if there is third-party code relying on the current behavior of find_key_name(), they could have problems.

Change-Id: I0470422a6e6514af98beb83e884178ee7f341ccd