Comment 2 for bug 1237013

Revision history for this message
Aaron Wells (u-aaronw) wrote :

To update this with some discussion we had on IRC -- the skin sylesheet is a dwoo template, so the theme can override it and "turn skins off" that way, by making it so that a Page's skin doesn't have any bearing on how the Page is displayed.

But, this patch is meant to go a bit farther, and also hide the Portfolio -> Skins page, and the "Skins" tab when editing a Page. In effect, it's the same as doing $cfg->skins = false;, or of turning skins off for the user's institution.

I'm somewhat against the feature, because I think there is too much potential for user confusion in letting Themes turn features on and off. This would be especially true if the site has user-picked themes turned on, or page themes turned on. The user changes their theme, and suddenly they can't find the Portfolio->Skins page anymore.

Or even via Institution themes it could be confusing -- the Institution admin turns skins on for their Institution, but they unknowingly pick a Theme that has skins turned off. They wonder, hey, why is there no Portfolio->Skins page?