Improve comment moderation status labels

[Aaron Wells]

With the approval of bugfix https://bugs.launchpad.net/mahara/+bug/1088609 , the user interface for comment moderation has become somewhat confusing, because comments that are awaiting moderation, and comments that were submitted private, both show up as simply "This comment is private". Consider this:

1. Activate anonymous comments on your Mahara site
2. Create a user Page. Make it public, and turn on comments and comment moderation.
3. Log out, go to the Page, and place an anonymous comment, on which you tick the "Make public" checkbox.
4. On the same Page, place an anonymous comment on which you *untick* the "Make public" checkbox.
5. Log in to the site as the Page owner and go to the page.

Expected Result: The private comment should say "This comment is private". The comment which is awaiting moderation should say "This comment is awaiting your approval to be made public", and should have a "Make public" button.

Actual Result: You will see two comments, both of which list their status as "This comment is private." One will have a "Make public" button, and the other will not. There is no explanation as to why one can be made public and the other can't.

So, I propose we improve the labels a bit:

1. Non-anonymous author submitted the comment as "private", neither side has pressed "Make public" yet:
  - Author sees "This comment is private | [Make public button]"
  - Owner sees "This comment is private | [Make public button]"

2. Non-anonymous author submitted the comment as "public", or pressed "Make public" button, and Page owner hasn't pressed "Make public" yet:
  - Author sees "This comment is private | You have requested that this comment be made public." (no change)
  - Owner sees "This comment is private | The author has requested to make this comment public. | [Make public button]"

3. Non-anonymous author submitted the comment as "private", and Page owner pressed "Make public", and author hasn't agreed yet:
 - Author sees "This comment is private | The page owner has requested to make this comment public. | [Make public button]"
 - Owner sees: "This comment is private | You have requested that this comment be made public."

4. Anonymous author submitted the comment as "public", Page owner hasn't pressed "Make public" yet:
  - Author: "Can't see comment"
  - Owner sees: "This comment is private | The author has requested to make this comment public | [Make public button]"

5. Anonymous author submitted the comment as "private"
  - Author: Can't see comment
  - Owner sees: "This comment is private"

[Aaron Wells (u-aaronw)]

The other issue with the current labels, is that for comments made by non-anonymous users, there are no indications to the Page Owner as to whether clicking "Make public" will actually make the comment public (because the Author has requested it already) or whether it will just ask the Author to make the comment public. The labels I proposed here will help with this.

It might also make sense to change the labeling of the "Make public" button, because in many cases it is not actually making it public, but is only requesting that it be made public. But... "Make public" is nice & succinct, so maybe it's good enough.