Comment moderation of anonymous comments can't make them public

[Kristina Hoeppner]

https://mahara.org/interaction/forum/topic.php?id=5120

Tested on demo.mahara.org (1.6 stable)

When comment moderation is turned on and you place an anonymous comment, it cannot be made public. Comments of regular users with logins are not affected.

[Robert Lyon (rlyon)]

https://reviews.mahara.org/#/c/2071/

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/2071
Committed: http://gitorious.org/mahara/mahara/commit/845da9e80e6000d74274997da32e93b6336305a4
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 845da9e80e6000d74274997da32e93b6336305a4
Author: rlyon <email address hidden>
Date: Fri Apr 19 21:11:09 2013 +1200

Allow moderation of anonymous comments (Bug #1088609)

Adding the Make Public button visible when author id is
not set (anonymous user) only when owner of artefact is
also viewer of page.

Change-Id: I33b544a7772becb489b8019b9bce496bde670094
Signed-off-by: rlyon <email address hidden>

[Aaron Wells (u-aaronw)]

While testing this out, I found some other issues with comments moderation, which I have opened as separate bugs:

https://bugs.launchpad.net/mahara/+bug/1171310 - Can bypass comment moderation by editing a comment
https://bugs.launchpad.net/mahara/+bug/1171311 - No one can moderate comments on Group pages
https://bugs.launchpad.net/mahara/+bug/1171315 - Improve comment moderation status labels

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/2079
Committed: http://gitorious.org/mahara/mahara/commit/caf8d6335c74a3c358f768c584537685c10ff382
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.7_STABLE

commit caf8d6335c74a3c358f768c584537685c10ff382
Author: rlyon <email address hidden>
Date: Fri Apr 19 21:11:09 2013 +1200

Allow moderation of anonymous comments (Bug #1088609)

Adding the Make Public button visible when author id is
not set (anonymous user) only when owner of artefact is
also viewer of page.

Signed-off-by: rlyon <email address hidden>
(cherry picked from commit 845da9e80e6000d74274997da32e93b6336305a4)

Change-Id: I9c9e7992f83ccf370b428bda7a4f26fb20196857
Signed-off-by: Aaron Wells <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/2078
Committed: http://gitorious.org/mahara/mahara/commit/2099810bb454e36b9a5e126d91a0c60059e8ee7c
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.6_STABLE

commit 2099810bb454e36b9a5e126d91a0c60059e8ee7c
Author: rlyon <email address hidden>
Date: Fri Apr 19 21:11:09 2013 +1200

Allow moderation of anonymous comments (Bug #1088609)

Adding the Make Public button visible when author id is
not set (anonymous user) only when owner of artefact is
also viewer of page.

Signed-off-by: rlyon <email address hidden>
(cherry picked from commit 845da9e80e6000d74274997da32e93b6336305a4)

Change-Id: I19ba2ab6ffabd3849ba4f6be7be5cb2c0656eaa1
Signed-off-by: Aaron Wells <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/2077
Committed: http://gitorious.org/mahara/mahara/commit/89476fa64ce2cd9631caccbfb0a57e1599e73696
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.5_STABLE

commit 89476fa64ce2cd9631caccbfb0a57e1599e73696
Author: rlyon <email address hidden>
Date: Fri Apr 19 21:11:09 2013 +1200

Allow moderation of anonymous comments (Bug #1088609)

Adding the Make Public button visible when author id is
not set (anonymous user) only when owner of artefact is
also viewer of page.

Signed-off-by: rlyon <email address hidden>
(cherry picked from commit 845da9e80e6000d74274997da32e93b6336305a4)

Change-Id: Ie43e147fa53a81c19a77302d103efc842f590507
Signed-off-by: Aaron Wells <email address hidden>

[Aaron Wells (u-aaronw)]

I updated 4 more of them: https://reviews.mahara.org/2117

[Aaron Wells (u-aaronw)]

Whoops, ignore that previous comment. It was meant for another bug.