Comment 2 for bug 1103942

Thanks very much for providing this code, Gregor! :) And I'm sorry it took us so long to get around to reviewing it.

The basic functionality works: I am able to attach files to items in my Achievements, Education, and Employment sections of my resume. These attachments are then listed with download links if I list those resume sections on one of my pages. They also show up under the Content/Files page, in a new directory called "resumefiles".

I do notice a few issues, though:

1. When I'm on the screen that lists my Achievements (or E&E) (i.e. /artefact/resume/employment.php ), and I mouse over the paperclip icon at the top of the column that say how many attachments each item has, the mouse pointer changes to one that indicates it's a clickable link, even though it isn't. (This is probably a CSS styling issue)

2. On that same list screen ( /artefact/resume/employment.php ), when I click on one of my achievements' names to view its description, the list of attachments is also shown, but the attachments are only named, not shown with a clickable link, so I can't tell what's in them easily.

3. The resume item editing screen ( /artefact/resume/editcomposite.php?id=2&artefact=5 ) only lets you add items; it doesn't let you remove them or re-order them, or tell you which ones you've already attached.

4. The mechanism to add files is a simple file upload button, so you can't pick files you've already uploaded into Mahara.

5. Again on the item editing screen, if I've attached a series of files but left out one of the required fields so that the form fails validation, the reloaded form will be lacking all the files I've just attached.

I'm not sure that these problems are all necessarily blockers... as I said before, the code works. It might be worthwhile to take an incremental approach. Which is to say, upstream this code with these non-blocker issues so at least it gets out there, and then come back and fix them as we have the resources to do so.