Undoing changes to the ArtefactTypeResumeComposite class signature
Bug 1103942: Resume attachments included two unnecessary changes to
the ArtefactTypeResumeComposite class which will break dependent code.
First, it added a new abstract function. This will cause any file
that contains a subclass that hasn't implemented that abstract function
to error out. So I'm providing a sensible default implementation
instead of making the function abstract.
Second, it adds a Pieform as the first parameter to ensure_composite()
to make it print Pieform errors. New parameters should always be added
as the last parameter to a function, with a default value, so that
existing calls to the method will still work. Additionally, there's
no need for the Pieforms logic to be in that call, since this function
is often used in a non-Pieforms context. I've refactored out the need
for that parameter.
Reviewed: https:/ /reviews. mahara. org/2530 gitorious. org/mahara/ mahara/ commit/ d88b94001ec9980 536f278cadd5fe8 27e32f95cb
Committed: http://
Submitter: Aaron Wells (<email address hidden>)
Branch: master
commit d88b94001ec9980 536f278cadd5fe8 27e32f95cb
Author: Aaron Wells <email address hidden>
Date: Thu Sep 26 17:05:48 2013 +1200
Undoing changes to the ArtefactTypeRes umeComposite class signature
Bug 1103942: Resume attachments included two unnecessary changes to umeComposite class which will break dependent code.
the ArtefactTypeRes
First, it added a new abstract function. This will cause any file
that contains a subclass that hasn't implemented that abstract function
to error out. So I'm providing a sensible default implementation
instead of making the function abstract.
Second, it adds a Pieform as the first parameter to ensure_composite()
to make it print Pieform errors. New parameters should always be added
as the last parameter to a function, with a default value, so that
existing calls to the method will still work. Additionally, there's
no need for the Pieforms logic to be in that call, since this function
is often used in a non-Pieforms context. I've refactored out the need
for that parameter.
Change-Id: I48b1f2375def6e d6aafdac389fcbb 120ad04d359
Signed-off-by: Aaron Wells <email address hidden>