Mahara

Pagination links are broken due to encoding of encoded ampersands

Bug #1089282 reported by Ruslan Kabalin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Ruslan Kabalin
Mahara 1.6.3
1.5
Fix Released
High
Ruslan Kabalin
Mahara 1.5.8
1.7
Fix Released
High
Ruslan Kabalin
Mahara 1.7.0

Bug Description

Hardcoded '&' after sanitisation becomes '&' at the output. Regression caused by bug #1079498. The patch will follow.

See original description
Ruslan Kabalin (rkabalin)
Changed in mahara:
assignee: nobody → Ruslan Kabalin (rkabalin)
status: New → Confirmed
importance: Undecided → High
milestone: none → 1.6.3
Revision history for this message
Ruslan Kabalin (rkabalin) wrote :

Master: https://reviews.mahara.org/#/c/1913/
1.6: https://reviews.mahara.org/#/c/1915/
1.5: https://reviews.mahara.org/#/c/1916/

Ruslan Kabalin (rkabalin)
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/1913
Committed: http://gitorious.org/mahara/mahara/commit/8854107e6df63c505ec4ab9127e1738d59b36de7
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 8854107e6df63c505ec4ab9127e1738d59b36de7
Author: Ruslan Kabalin <email address hidden>
Date: Wed Dec 12 10:21:44 2012 +0000

    Fix pagination double encoding (bug #1089282)

    Change-Id: Iee6a362c264eed24dea92ea7b86b9b29fab2e9ee
    Signed-off-by: Ruslan Kabalin <email address hidden>

Revision history for this message
Son Nguyen (ngson2000) wrote :

We also need to fix the double encoding of &amp; when defining the 'url' for a pagination

For example, line 1628 in lib/group.php

Revision history for this message
Ruslan Kabalin (rkabalin) wrote :

You had to mentioned bug #1090203 here :) Would save some of my time doing the same :)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1915
Committed: http://gitorious.org/mahara/mahara/commit/9fdfb68b6d46d4e329a8370172f31c07c35dcec6
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.6_STABLE

commit 9fdfb68b6d46d4e329a8370172f31c07c35dcec6
Author: Ruslan Kabalin <email address hidden>
Date: Wed Dec 12 10:21:44 2012 +0000

    Fix pagination double encoding (bug #1089282)

    Change-Id: Iee6a362c264eed24dea92ea7b86b9b29fab2e9ee
    Signed-off-by: Ruslan Kabalin <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1916
Committed: http://gitorious.org/mahara/mahara/commit/e7e520c481a05179a6cbab849ddb5a7e6eaeda80
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.5_STABLE

commit e7e520c481a05179a6cbab849ddb5a7e6eaeda80
Author: Ruslan Kabalin <email address hidden>
Date: Wed Dec 12 10:21:44 2012 +0000

    Fix pagination double encoding (bug #1089282)

    Change-Id: Iee6a362c264eed24dea92ea7b86b9b29fab2e9ee
    Signed-off-by: Ruslan Kabalin <email address hidden>

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: Confirmed → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.